bot.py semantic fixes (python-telegram-bot#774)

Eldinnie · tsnoam · commit 56f7d18853e4 · 2017-08-08T00:13:32.000+03:00
offset for get_user_profile_photo can be zero.
edit_message_caption should raise ValueError in compliance with other methods. Also changed to snake_case
edit_message_reply_markup was even weirder
diff --git a/telegram/bot.py b/telegram/bot.py
@@ -1156,7 +1156,7 @@ def get_user_profile_photos(self, user_id, offset=None, limit=100, timeout=None,
 
         data = {'user_id': user_id}
 
-        if offset:
+        if offset is not None:
             data['offset'] = offset
         if limit:
             data['limit'] = limit
@@ -1438,8 +1438,8 @@ def edit_message_caption(self,
         """
 
         if inline_message_id is None and (chat_id is None or message_id is None):
-            raise TelegramError(
-                'editMessageCaption: Both chat_id and message_id are required when '
+            raise ValueError(
+                'edit_message_caption: Both chat_id and message_id are required when '
                 'inline_message_id is not specified')
 
         url = '{0}/editMessageCaption'.format(self.base_url)
@@ -1494,8 +1494,8 @@ def edit_message_reply_markup(self,
         """
 
         if inline_message_id is None and (chat_id is None or message_id is None):
-            raise TelegramError(
-                'editMessageCaption: Both chat_id and message_id are required when '
+            raise ValueError(
+                'edit_message_reply_markup: Both chat_id and message_id are required when '
                 'inline_message_id is not specified')
 
         url = '{0}/editMessageReplyMarkup'.format(self.base_url)
