Skip to content

Commit 964ee98

Browse files
MylesBorinsphillipj
authored andcommitted
labels: map dont-land-on-v4(6).x for http2 (nodejs#152)
* labels: map dont-land-on-v4(6).x for http2 * labels: added tests for map dont-land-on-v4(6).x for http2 * labels: map dont-land-on-v4(6).x for lib/http2
1 parent 4db555d commit 964ee98

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

lib/node-labels.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const subSystemLabelsMap = new Map([
3030
[/^src\/node_zlib/, ['c++', 'zlib']],
3131
[/^src\/tracing/, ['c++', 'tracing']],
3232
[/^src\/node_api/, ['c++', 'n-api', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
33-
[/^src\/node_http2/, ['c++', 'http2']],
33+
[/^src\/node_http2/, ['c++', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
3434

3535
// don't label python files as c++
3636
[/^src\/.+\.py$/, 'lib / src'],
@@ -73,8 +73,8 @@ const subSystemLabelsMap = new Map([
7373
[/^deps\/uv\//, 'libuv'],
7474
[/^deps\/v8\/tools\/gen-postmortem-metadata\.py/, ['V8 Engine', 'post-mortem']],
7575
[/^deps\/v8\//, 'V8 Engine'],
76-
[/^deps\/nghttp2\/nghttp2\.gyp/, ['build', 'http2']],
77-
[/^deps\/nghttp2\//, 'http2'],
76+
[/^deps\/nghttp2\/nghttp2\.gyp/, ['build', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
77+
[/^deps\/nghttp2\//, ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
7878
[/^deps\/([^/]+)/, '$1'],
7979

8080
/* JS subsystems */
@@ -87,6 +87,7 @@ const subSystemLabelsMap = new Map([
8787
[/^lib\/\w+\/v8_prof_/, 'tools'],
8888
[/^lib\/\w+\/socket_list/, 'net'],
8989
[/^lib\/\w+\/streams$/, 'stream'],
90+
[/^lib\/.*http2/, ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
9091
[/^lib\/internal\/url\.js$/, ['url-whatwg',
9192
'dont-land-on-v4.x', 'dont-land-on-v6.x']],
9293
// All other lib/ files map directly

test/unit/node-labels.test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -615,16 +615,17 @@ tap.test('label: "build" when ./android-configure has been changed', (t) => {
615615
});
616616

617617
[
618-
[ ['http2'],
618+
[ ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
619619
['lib/http2.js',
620620
'lib/internal/http2/core.js',
621621
'deps/nghttp2/lib/nghttp2_buf.c'] ],
622-
[ ['c++', 'http2'],
622+
[ ['c++', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
623623
['src/node_http2.cc',
624624
'src/node_http2.h',
625625
'src/node_http2_core.h',
626626
'src/node_http2_core-inl.h'] ],
627-
[ ['build', 'http2'], ['deps/nghttp2/nghttp2.gyp'] ],
627+
[ ['build', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
628+
['deps/nghttp2/nghttp2.gyp'] ],
628629
[ ['doc', 'http2'], ['doc/api/http2.md'] ]
629630
].forEach((info) => {
630631
const labels = info[0]

0 commit comments

Comments
 (0)