feat: join get_base_config and get_public_config api - #714

adminforth/modules/restApi.ts:984

• This endpoint already computed userResource earlier, but it does another resources.find() for the same usersResourceId. Reuse userResource to avoid duplicate work and reduce the chance of the two lookups diverging in future refactors.

        const usersResource = this.adminforth.config.resources.find((res) => res.resourceId === this.adminforth.config.auth.usersResourceId);
        const defaultUserExists = await this.adminforth.resource(usersResource.resourceId).get(Filters.EQ(usernameField, 'adminforth')) ? true : false;

adminforth/modules/restApi.ts:903

• Variable name public_config uses snake_case, while the surrounding codebase uses camelCase (e.g., userResource, loggedInPart). Renaming to publicConfig would improve consistency and readability.

This issue also appears on line 983 of the same file.

        const public_config = {
          brandName: this.adminforth.config.customization.brandName,
          usernameFieldName: usernameColumn.label,
          loginBackgroundImage: this.adminforth.config.auth.loginBackgroundImage,
          loginBackgroundPosition: this.adminforth.config.auth.loginBackgroundPosition,

adminforth/servers/express.ts:362

• This processAuthorizeCallbacks method is now dead code. The authorize flow was moved into AdminForthAuth.authorizeByCookies / runAdminUserAuthorizeHooks, and the authorize middleware no longer calls this method. A repo-wide search finds no remaining callers, so this method (and the toReturn mutation pattern it relies on) can be removed to avoid leaving an unused, diverging copy of the hook logic (note it uses if (!allowed || error) whereas authorizeByCookies uses if (!allowed)).

  async processAuthorizeCallbacks(adminUser: AdminUser, toReturn: { error?: string, allowed: boolean }, response: Response, extra: HttpExtra) {
    const { allowed, error } = await this.adminforth.auth.runAdminUserAuthorizeHooks(adminUser, response as any, extra);
    if (!allowed || error) {
      // delete all items from toReturn and add these:
      toReturn.allowed = allowed;
      toReturn.error = error;
    }
  }