Merged
Conversation
Owner
|
Wondering if it'd be worth just inlining the conversion as a ternary? It can bypass |
Collaborator
Author
|
Word. Wasn't sure if there would be other special cases in the future, but that makes sense for now. Updating. |
nathancahill
force-pushed
the
features/support-classname
branch
from
8649d87 to
f4da1f0
Compare
Collaborator
Author
|
Great, now it only adds 17 bytes. (548 bytes to 565 bytes). |
Owner
|
sweet! |
developit
approved these changes
Apr 29, 2017
Owner
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the test too!
|
Would be great to have a npm release with this patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of JSX uses
classNameas an attribute forclass, sinceclassis a reserved keyword in ES6. This adds support. Adds 23 bytes (548 bytes to 571 bytes).