WIP: Subscribers now receive update & params#25
Open
krzepah wants to merge 2 commits intodevelopit:masterfrom
Open
WIP: Subscribers now receive update & params#25krzepah wants to merge 2 commits intodevelopit:masterfrom
krzepah wants to merge 2 commits intodevelopit:masterfrom
Conversation
Owner
|
How does this work with batching though? |
Author
|
I expended the Do you have an idea of how I should stress it a little more ? note : 4 because the previous test already sets it to 2 |
Author
|
Hei, Pretty sure the PR is buggy, I've problems when a project is built. I will need to dig in to find what's happening, "tagging" it as WIP until then edit : oops ! actually I now have an e2e test passing that uses setState with this PR ! I'm going to work more on it 🎉 the problem resorbed by itself so I guess I was doing something wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has developit/unistore#167 dependency