feat: Support customizing the modern output via "exports"#784
Merged
developit merged 4 commits intodevelopit:masterfrom Jun 3, 2021
rschristian:feat/modernFileName
Merged
feat: Support customizing the modern output via "exports"#784developit merged 4 commits intodevelopit:masterfrom rschristian:feat/modernFileName
developit merged 4 commits intodevelopit:masterfrom
rschristian:feat/modernFileName
Conversation
🦋 Changeset detectedLatest commit: 3ccfefd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
developit
reviewed
Jan 7, 2021
src/index.js
Outdated
| ); | ||
| mainsByFormat.modern = replaceName( | ||
| (pkg.syntax && pkg.syntax.esmodules) || pkg.esmodule || 'x.modern.js', | ||
| (typeof pkg.exports === 'string' && pkg.exports) || |
Owner
There was a problem hiding this comment.
This works for the main case. I'm wondering - maybe we could walk the exports object to find matching import entries?
function walk(exports) {
if (typeof exports === 'string') return exports;
return walk(exports['.'] || exports.import || exports.module);
}
walk(pkg.exports)
Collaborator
Author
There was a problem hiding this comment.
Certainly could. I started to think about this but had reservations on whether or not users would expect all keys (or at least the ones in the spec?) to be supported. If they have a "require", would they then expect a matching output file? Not sure.
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Merged
developit
approved these changes
Jun 3, 2021
developit
approved these changes
Jun 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #783
Allows users to customize modern output file name with
exportslike they can withesmodules.