Repository navigation
Preserve equals signs in define mapping values - #1102
Open
Aschenbath wants to merge 2 commits into
Open
Aschenbath wants to merge 2 commits into
Aschenbath wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4f21a2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--define TOKEN=abc==currently replacesTOKENwith"abc", and expressions containing===or=>are truncated and can fail to build. Split mappings at the first equals sign so the complete value reaches literal/expression conversion. Preserve the distinction between empty and missing values.Includes a patch changeset for the next release. Adds 12 unit cases and a build fixture covering padded tokens, URLs, quotes, equality and arrow expressions, neighboring definitions, and value processors. The original implementation fails 11 unit cases and the new build fixture. With the fix, the full suite passes on the project's CI runtime, Node 14.21.3: 78 tests and 343 snapshots. Lint and both bootstrap/self-build stages pass. A separately installed package builds and executes CommonJS, ESM and UMD outputs with intact values on Node 24.22.0.
Node 24's complete suite has 54 mismatches in existing gzip-size snapshots; the Node 14 suite passes without changing existing snapshots. A separate Codex agent reviewed 1,608 generated mapping cases and found no unintended behavior changes.
Fixes #1024.
This change and its tests were prepared with assistance from OpenAI Codex. The independent review described above was performed by another Codex agent.