Merged
Conversation
paranoidjk
reviewed
Aug 30, 2017
| return function(e) { | ||
| const cache = component._linkedStates || (component._linkedStates = {}); | ||
|
|
||
| return cache[`${key}\n${eventPath}`] || (cache[`${key}\n${eventPath}`] = function(e) { |
There was a problem hiding this comment.
why not make ${key}\n${eventPath} to be a variable?
Author
There was a problem hiding this comment.
That's a good suggestion and I normally would do that in my own code but in this case it increases the gzipped file size from 315 bytes to 317 bytes. I guess that's a pretty inconsequential difference but as the philosophy of preact is "as small a file size as possible" I thought that maybe the smaller file size would be preferable. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module isn't that helpful without it! 😄
Resolves issue #4