babel-transform-jsx: handle JSX fragments#85
Merged
jviide merged 5 commits intodevelopit:masterfrom Jun 13, 2019
Merged
Conversation
Owner
|
Isn't the default behaviour what folks want here? // input:
<Fragment>
<div />
<div />
</Fragment>
// output:
html`
<${Fragment>
<div />
<div />
</${Fragment}>
` |
Contributor
Author
No. |
Owner
|
@blikblum seems reasonable. I'll need a bit to properly review. |
developit
requested review from
developit and
jviide
and removed request for
jviide
jviide
reviewed
Jun 5, 2019
Collaborator
jviide
left a comment
jviide
left a comment
There was a problem hiding this comment.
I think the idea is sound 👍 Added a couple of suggestions regarding the structure and formatting, and added a suggestion to use this opportunity to make the plugin more robust overall.
developit
approved these changes
Jun 11, 2019
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes jsx to htm babel transform handle JSX fragments both React.Fragment and short (<></>) syntax.
Basically removes the fragment nodes