Allow slashes in unquoted prop values (unless immediately followed by >)#112
Merged
jviide merged 3 commits intodevelopit:masterfrom Jul 29, 2019
jviide:issue-106
Merged
Allow slashes in unquoted prop values (unless immediately followed by >)#112jviide merged 3 commits intodevelopit:masterfrom jviide:issue-106
jviide merged 3 commits intodevelopit:masterfrom
jviide:issue-106
Conversation
Collaborator
Author
|
Added a commit that updates the main README.md to reflect the slighly increased size of the mini build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the parsing logic (and adds related tests) so that slashes in unquoted property values are allowed. For example
<abba prop=val/ue><//>parses toh('ab', { prop: 'val/ue' }). The exception is when the/is immediately followed by>-<abba prop=value/>parses as a self-closing elementh('ab', { prop: 'value' }).Slashes in tag names and property names will still self-close the element. For example
<ab/ba prop=value>parses toh('ab', null), and<abba pr/op=value>parses toh('abba', { pr: true }).The regular build size grows by 8 bytes (588 B -> 596 B) and the mini build size grows by 9 bytes (417 B -> 426 B). The performance doesn't seem to be affected, based on
test:perfruns with V8 on MacOS 10.14.6.Closes #106.