Conversation
|
@microsoft-github-policy-service agree |
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the proposal! Left a few questions.
|
|
||
| ## Proposed Solution | ||
|
|
||
| Extend the Dev Container Feature Options Schema by introducing `array` and `object` as valid types for feature options. These new types will enable developers to create more complex and customizable features. |
There was a problem hiding this comment.
What types of values would be supported? Maybe limiting it to strings and booleans would keep it simple and aligned with the existing types.
|
|
||
| # Install dependencies | ||
| echo "Installing dependencies..." | ||
| for package in "${DEPENDENCIES[@]}"; do |
There was a problem hiding this comment.
This seems to be Bash specific syntax. How would this work with the Bourne shell /bin/sh? The Bourne shell is used for the install scripts to allow for compatibility with distributions not including Bash by default like Alpine Linux.
Graysonbarton
left a comment
Graysonbarton
left a comment
There was a problem hiding this comment.
Signed-off-by: Grayson Barton gveyron18@outlook.com
Graysonbarton
left a comment
Graysonbarton
left a comment
There was a problem hiding this comment.
Signed-off-by: Grayson Barton gveyron18@outlook.com
3 participants
The following provides a clear proposal for the inclusion of the array and object types for Feature options. The updated schema validate JSON Schema 7 via https://www.jsonschemavalidator.net/ and was tested against the samples provided in the proposal.