Skip to content

docs: add devcontainer-features and devcontainer-templates from irfansofyana#508

Merged
AlvaroRausell merged 3 commits intodevcontainers:gh-pagesfrom
irfansofyana:add-kcat-apt
Nov 20, 2025
Merged

docs: add devcontainer-features and devcontainer-templates from irfansofyana#508
AlvaroRausell merged 3 commits intodevcontainers:gh-pagesfrom
irfansofyana:add-kcat-apt

Conversation

@irfansofyana
Copy link
Copy Markdown
Contributor

@irfansofyana irfansofyana commented Jan 2, 2025 •
edited
Loading

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Hi folks, I'm adding my devcontainer-features: https://github.com/irfansofyana/devcontainer-features currently it contains kafkacat/kcat CLI that I cannot found in other features hence I created it.

I also add https://github.com/irfansofyana/devcontainer-templates to add a few templates, currently it contains go-template (a template for go developer)

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@irfansofyana irfansofyana requested a review from a team as a code owner January 2, 2025 06:56
@irfansofyana irfansofyana changed the title docs: add devcontainer-features from irfansofyana docs: add devcontainer-features and devcontainer-templates from irfansofyana Jan 9, 2025
@Kaniska244
Copy link
Copy Markdown

Kaniska244 commented Feb 20, 2025 •
edited
Loading

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards,
Kaniska

@irfansofyana
Copy link
Copy Markdown
Contributor Author

irfansofyana commented Feb 20, 2025

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards, Kaniska

oopss my bad it's a typo, it should be https://github.com/irfansofyana/devcontainer-templates, will fix it

@irfansofyana
Copy link
Copy Markdown
Contributor Author

irfansofyana commented Feb 20, 2025

please review it again @Kaniska244

@Kaniska244
Copy link
Copy Markdown

Kaniska244 commented Feb 24, 2025

Change approved. This can be merged.

eljog
eljog previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
Please resolve conflicts

@irfansofyana irfansofyana requested a review from eljog March 1, 2025 02:25
@irfansofyana
Copy link
Copy Markdown
Contributor Author

irfansofyana commented Mar 7, 2025

Please re-review it again @eljog

ddoyle2017
ddoyle2017 previously approved these changes Apr 9, 2025
View reviewed changes
@ddoyle2017
Copy link
Copy Markdown

ddoyle2017 commented Apr 9, 2025

@irfansofyana changes approved! Sorry, but can you address the merge conflicts again before we merge this?

AlvaroRausell
AlvaroRausell approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for the delay!

@AlvaroRausell AlvaroRausell merged commit 10e5208 into devcontainers:gh-pages Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljog eljog Awaiting requested review from eljog

2 more reviewers

@AlvaroRausell AlvaroRausell AlvaroRausell approved these changes

@ddoyle2017 ddoyle2017 ddoyle2017 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@irfansofyana @Kaniska244 @ddoyle2017 @eljog @AlvaroRausell