Skip to content

Commit 87c4492

Browse files
author
Kaushik Gopal
committed
refactor: still don't know what the hell i'm doing with buffer
1 parent 57621fe commit 87c4492

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

app/src/main/java/com/morihacky/android/rxjava/BufferDemoFragment.java

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public class BufferDemoFragment
4343
@Override
4444
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
4545
super.onActivityCreated(savedInstanceState);
46-
_setupLogAdapter();
46+
_setupLogger();
4747

4848
_bufferedObservable = _getBufferedObservable();
4949
_observer = _getObserver();
@@ -52,6 +52,9 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
5252

5353
@OnClick(R.id.btn_start_operation)
5454
public void onButtonTapped() {
55+
Timber.d("--------- GOT A TAP");
56+
_tapCount += 1;
57+
_log("GOT A TAP");
5558
_bufferedObservable.subscribeOn(Schedulers.io())
5659
.observeOn(AndroidSchedulers.mainThread())
5760
.subscribe(_observer);
@@ -67,7 +70,6 @@ private Observable<List<Integer>> _getBufferedObservable() {
6770
@Override
6871
public void call(Subscriber<? super Integer> subscriber) {
6972
subscriber.onNext(1);
70-
// send one tap
7173
}
7274

7375
}).buffer(2, TimeUnit.SECONDS);
@@ -91,10 +93,16 @@ public void onError(Throwable e) {
9193

9294
@Override
9395
public void onNext(List<Integer> integers) {
94-
for (int i : integers) {
95-
_tapCount += i;
96+
Timber.d("--------- onNext");
97+
98+
if (integers.size() > 0) {
99+
for (int i : integers) {
100+
_tapCount += i;
101+
}
102+
onCompleted();
103+
} else {
104+
Timber.d("--------- No taps received ");
96105
}
97-
onCompleted();
98106
}
99107
};
100108
}
@@ -111,7 +119,7 @@ public View onCreateView(LayoutInflater inflater,
111119
return layout;
112120
}
113121

114-
private void _setupLogAdapter() {
122+
private void _setupLogger() {
115123
_logs = new ArrayList<String>();
116124
_adapter = new LogAdapter(getActivity(), new ArrayList<String>());
117125
_logsList.setAdapter(_adapter);

0 commit comments

Comments
 (0)