Skip to content

Repair wp/5.4 branch Actions: Add timeouts to CI jobs that have none - #815

Draft
desrosj wants to merge 1 commit into
fix-actions-5.4/remove-rn-workflowsfrom
fix-actions-5.4/add-job-timeouts
Draft

desrosj wants to merge 1 commit into
fix-actions-5.4/remove-rn-workflowsfrom
fix-actions-5.4/add-job-timeouts

Conversation

@desrosj

@desrosj desrosj commented Oct 20, 2026

Copy link
Copy Markdown
Owner

What?

Adds timeout-minutes to the CI jobs on wp/5.4 that don't have one, using trunk's values:

File Job Check Minutes Trunk
static-checks.yml check Static Analysis All 30 30
unit-test.yml unit-php PHP 20 20
end2end-test.yml admin Admin e2e 45 45 (e2e-playwright)

unit-test.yml's unit-js (JavaScript) job gets no timeout, matching trunk, where it has none.

Why?

Without timeout-minutes, a stuck job runs until GitHub's 360-minute default. On this branch, the Admin - 2 job of run https://github.com/desrosj/gutenberg/actions/runs/35672857737 hung in its npm install and build step until it was cancelled at 360 minutes.

How?

The Static Analysis and Admin e2e values come from WordPress@27f57c9 (WordPress#80801), which added job timeouts on trunk; the Admin e2e job takes the 45 minutes it gives trunk's Playwright e2e jobs. The PHP value comes from WordPress@9ee17a7 (WordPress#46510), which created trunk's PHP unit test job with a 20-minute timeout.

All of them leave plenty of headroom on this branch. The slowest successful runs since 2026-09-22 took 4.6 minutes (Static Analysis), 3.4 minutes (PHP) and 7.6 minutes (Admin e2e); a failing Admin e2e run took 9.5 minutes.

Each timeout-minutes goes directly before the job's if:. There are no step-level timeouts.

Testing Instructions

actionlint passes on the changed workflows. Applying every later PR in this stack on top of this change is conflict-free. Check that the Static Analysis, Unit Tests and End-to-End Tests runs on this PR pass as before.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

https://claude.ai/code/session_013wZdkg9DSpSbQmRpBymFfV

Without `timeout-minutes`, a stuck job runs until GitHub's 360-minute
default. Set the Static Analysis, PHP unit test and Admin e2e jobs to
trunk's values: 30, 20 and 45 minutes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013wZdkg9DSpSbQmRpBymFfV
@desrosj
desrosj added this pull request to stack #817 October 20, 2026 23:52
@desrosj
desrosj removed this pull request from stack #817 October 21, 2026 12:58
@desrosj
desrosj added this pull request to stack #833 October 21, 2026 12:59
@desrosj
desrosj removed this pull request from stack #833 October 21, 2026 20:45
@desrosj
desrosj added this pull request to stack #845 October 21, 2026 20:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant