Skip to content

Repair wp/6.5 branch Actions: Test only the Node.js version this branch supports - #79

Closed
desrosj wants to merge 4 commits into
fix-actions-6.5/update-actions-to-latestfrom
fix-actions-6.5/single-node-version-testing
Closed

desrosj wants to merge 4 commits into
fix-actions-6.5/update-actions-to-latestfrom
fix-actions-6.5/single-node-version-testing

Conversation

@desrosj

@desrosj desrosj commented Aug 26, 2026

Copy link
Copy Markdown
Owner

What?

This trims the testing matrix for workflow files that test multiple versions of Node.js.

Additinoally, the check-latest: true input is removed from every actions/setup-node call.

Why?

These workflows tested both the current and next Node.js version when the branc was created to catch forward-compatibility issues early. Since this branch is only eligible for security updates, it will never run on anything but the Node.js version pinned in .nvmrc. Testing additional versions wastes time running Actions unnecessarily.

The check-latest: true input makes actions/setup-node re-check for a newer matching release on every single run, useful only while the pinned version is still receiving releases. Node.js 20.x has reached end-of-life.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj changed the base branch from fix-actions-6.5/remove-rn-workflows to fix-actions-6.5/update-actions-to-latest August 26, 2026 14:11
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch 3 times, most recently from e63becc to 539d58c Compare August 27, 2026 15:02
@desrosj
desrosj removed this pull request from stack #87 September 10, 2026 19:37
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch from 539d58c to 281beec Compare September 10, 2026 19:39
@desrosj
desrosj added this pull request to stack #190 September 10, 2026 19:40
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch 2 times, most recently from 77425da to 7291c2f Compare September 11, 2026 00:26
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch 3 times, most recently from 8806c94 to 22255a0 Compare September 11, 2026 02:30
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch from 22255a0 to a2a625f Compare September 14, 2026 01:57
@desrosj
desrosj marked this pull request as ready for review September 15, 2026 19:01
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This removes the `check-latest: true` input from every `actions/setup-node` call within:
- the composite `.github/setup-node/action.yml` action
- `build-plugin-zip.yml`
- `bundle-size.yml`
- `static-checks.yml`
- `pull-request-automation.yml`

`check-latest: true` makes `actions/setup-node` query the Node.js release index for a newer matching version on every run before falling back to its local tool cache. That's only useful when the Node.js version in use is still actively receiving new releases.

This branch pins Node.js `20` via `.nvmrc` which has reached end-of-life and will never be updated. This results in extra unnecessasry HTTP requests per run rather than a meaningful freshness check.
This removes the `node` matrix dimension from the `checks` job in `create-block.yml`. Unlike newer branches, this workflow has no `event`-based excludes tied to the `node` dimension, so only the matrix entry and job name need updating.

The `node-version` input for the `./.github/setup-node` step has been eliminated and the action will fall back to the value in the `.nvmrc` file.
This removes the `node` matrix dimension from the `unit-js` job in `unit-test.yml`. Since `node` was the job's only matrix dimension (this branch predates the shard-based splitting used on newer branches, and date tests run as a step within this same job rather than a separate `unit-js-date` job), the entire `strategy` block is removed.

The `node-version` input for the `./.github/setup-node` step has been eliminated and the action will fall back to the value in the `.nvmrc` file.
…-packages.yml`.

This removes the `check-latest: true` input from both `actions/setup-node`
calls in `publish-npm-packages.yml`, completing the change already made
elsewhere in this layer.

`check-latest: true` makes `actions/setup-node` query the Node.js release
index for a newer matching version on every run before falling back to its
local tool cache. That's only useful when the Node.js version in use is
still actively receiving new releases.

This branch pins Node.js `20` via `.nvmrc` which has reached end-of-life
and will never be updated. This results in extra unnecessary HTTP requests
per run rather than a meaningful freshness check.

This file didn't exist when the original removal commit was made in this
layer (it had been removed by a prior layer and has since been restored),
so it never received this change until now.
@desrosj
desrosj force-pushed the fix-actions-6.5/single-node-version-testing branch from a2a625f to bfa885a Compare September 15, 2026 19:22
@desrosj
desrosj removed this pull request from stack #190 September 15, 2026 21:18
@desrosj
desrosj added this pull request to stack #376 September 15, 2026 21:22
@desrosj

desrosj commented Sep 16, 2026

Copy link
Copy Markdown
Owner Author

Migrated to the real WordPress/gutenberg repository as WordPress#82991.

@desrosj desrosj closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant