Skip to content

Repair wp/6.6 branch Actions: Test only the Node.js version this branch supports - #76

Closed
desrosj wants to merge 4 commits into
fix-actions-6.6/update-actions-to-latestfrom
fix-actions-6.6/single-node-version-testing
Closed

desrosj wants to merge 4 commits into
fix-actions-6.6/update-actions-to-latestfrom
fix-actions-6.6/single-node-version-testing

Conversation

@desrosj

@desrosj desrosj commented Aug 26, 2026

Copy link
Copy Markdown
Owner

What?

This trims the testing matrix for workflow files that test multiple versions of Node.js.

Additinoally, the check-latest: true input is removed from every actions/setup-node call.

Why?

These workflows tested both the current and next Node.js version when the branc was created to catch forward-compatibility issues early. Since this branch is only eligible for security updates, it will never run on anything but the Node.js version pinned in .nvmrc. Testing additional versions wastes time running Actions unnecessarily.

The check-latest: true input makes actions/setup-node re-check for a newer matching release on every single run, useful only while the pinned version is still receiving releases. Node.js 20.x has reached end-of-life.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch from 90970e1 to 99888e3 Compare August 26, 2026 14:16
@desrosj
desrosj changed the base branch from fix-actions-6.6/remove-rn-workflows to fix-actions-6.6/update-actions-to-latest August 26, 2026 14:23
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch 2 times, most recently from 2855457 to cbc4bc3 Compare August 27, 2026 15:08
@desrosj
desrosj removed this pull request from stack #91 September 10, 2026 19:36
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch from cbc4bc3 to f115ac6 Compare September 10, 2026 19:36
@desrosj
desrosj added this pull request to stack #186 September 10, 2026 19:37
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch 2 times, most recently from 54bc0a1 to 4dea294 Compare September 11, 2026 00:27
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch 3 times, most recently from 49f78e5 to 103e8f2 Compare September 11, 2026 02:37
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 02:49
@desrosj
desrosj marked this pull request as draft September 11, 2026 03:22
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch from 103e8f2 to 1c17159 Compare September 14, 2026 01:34
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch from 1c17159 to 4e826c1 Compare September 14, 2026 19:18
@desrosj
desrosj marked this pull request as ready for review September 15, 2026 00:02
This removes the `check-latest: true` input from every `actions/setup-node` call within:
- the composite `.github/setup-node/action.yml` action
- `build-plugin-zip.yml`
- `bundle-size.yml`
- `pull-request-automation.yml`
- `static-checks.yml`

`check-latest: true` makes `actions/setup-node` query the Node.js release index for a newer matching version on every run before falling back to its local tool cache. That's only useful when the Node.js version in use is still actively receiving new releases.

This branch pins Node.js `20` via `.nvmrc` which has reached end-of-life and will never be updated. This results in extra unnecessasry HTTP requests per run rather than a meaningful freshness check.
This removes the `node` matrix dimension from the `checks` job in `create-block.yml`. The `os` matrix dimension is left in place since it's unrelated to the Node.js version.

The `node-version` input for the `./.github/setup-node` step has been eliminated and the action will fall back to the value in the `.nvmrc` file.
This removes the `node` matrix dimension from the `unit-js` job in `unit-test.yml`. The `unit-js-date` job's `strategy` is removed entirely, since `node` was its only matrix dimension.

The `node-version` input for the `./.github/setup-node` step has been eliminated in both jobs and the action will fall back to the value in the `.nvmrc` file.
…-packages.yml`.

Follow-up to this layer's original `check-latest` removal commit: `publish-npm-packages.yml` didn't exist on this branch at the time (it had been removed by the `remove-rn-workflows` layer and was restored afterward), so its two `actions/setup-node` calls never got the same treatment as every other workflow file.

`check-latest: true` makes `actions/setup-node` query the Node.js release index for a newer matching version on every run before falling back to its local tool cache. That's only useful when the Node.js version in use is still actively receiving new releases. This branch pins Node.js `20` via `.nvmrc`, which has reached end-of-life and will never be updated, so this only added unnecessary HTTP requests per run rather than a meaningful freshness check.
@desrosj
desrosj force-pushed the fix-actions-6.6/single-node-version-testing branch from 4e826c1 to a3e0392 Compare September 15, 2026 00:09
@desrosj
desrosj removed this pull request from stack #186 September 15, 2026 00:25
@desrosj
desrosj added this pull request to stack #354 September 15, 2026 00:26
@desrosj

desrosj commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82916. Closing this fork PR.

@desrosj desrosj closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant