Repository navigation
Repair wp/5.7 branch Actions: Only read the template slug when a template exists in the templates REST controller - #716
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #717
October 9, 2026 15:13
desrosj
removed this pull request from stack #717
October 9, 2026 19:50
desrosj
changed the base branch from
fix-actions-5.7/fix-widgets-controller-missing-name
to
wp/5.7
October 9, 2026 19:51
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 9, 2026 19:53
ddc8b65 to
f3baf87
Compare
desrosj
changed the base branch from
wp/5.7
to
fix-actions-5.7/fix-widgets-controller-missing-name
October 9, 2026 19:55
desrosj
added this pull request to stack #719
October 9, 2026 19:55
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 13, 2026 02:21
f3baf87 to
edaaf0c
Compare
github-actions
Bot
removed
[Tool] Create Block
[Tool] ESLint plugin
[Tool] Env
[Package] E2E Tests
labels
desrosj
force-pushed
the
fix-actions-5.7/fix-templates-controller-null-template
branch
from
October 13, 2026 02:41
edaaf0c to
680bd2b
Compare
desrosj
marked this pull request as ready for review
October 15, 2026 02:24
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84795. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In
WP_REST_Templates_Controller::prepare_item_for_database(), moves$changes->post_name = $template->sluginto the two branches where$templateexists.Why?
When a template is created,
$templateisnull, and the method reads$template->slugbefore checking for that. On PHP 8 this is a warning, sotest_create_itemfails on thePHP 8.0jobs:These endpoints first shipped in WordPress 5.8. On this branch they exist only as plugin code in
lib/, which isn't in any npm package and never reaches a WordPress 5.7 release. A small change here keeps the tests green, so security fixes for the packages WordPress 5.7 does ship can be verified reliably.How?
This is the same change as WordPress@046c82f (WordPress#32176), applied by hand because that commit doesn't cherry-pick here. Behavior is unchanged: updates still set
post_namefrom the template, andcreate_item()already sets it from the request.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code