Repository navigation
Repair wp/5.7 branch Actions: Use the Outline dropdown in the Site Editor save flow e2e test - #696
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #693
October 8, 2026 21:34
desrosj
marked this pull request as ready for review
October 8, 2026 21:36
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #693
October 9, 2026 14:02
desrosj
added this pull request to stack #710
October 9, 2026 14:03
desrosj
removed this pull request from stack #710
October 9, 2026 14:46
desrosj
added this pull request to stack #714
October 9, 2026 14:48
desrosj
removed this pull request from stack #714
October 9, 2026 15:13
desrosj
added this pull request to stack #717
October 9, 2026 15:13
desrosj
removed this pull request from stack #717
October 9, 2026 19:50
desrosj
changed the base branch from
fix-actions-5.7/pin-tt1-blocks-theme
to
wp/5.7
October 9, 2026 19:51
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 9, 2026 19:53
5a9b08c to
433eed0
Compare
desrosj
changed the base branch from
wp/5.7
to
fix-actions-5.7/pin-tt1-blocks-theme
October 9, 2026 19:55
desrosj
added this pull request to stack #719
October 9, 2026 19:55
desrosj
force-pushed
the
fix-actions-5.7/fix-site-editor-save-flow-outline-button
branch
from
October 13, 2026 02:41
433eed0 to
93f8cd6
Compare
Owner
Author
|
Moved to WordPress#84790. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the Site Editor "Save flow should work as expected" end-to-end test in
packages/e2e-tests/specs/experiments/multi-entity-saving.test.jsto select the header template part through Gutenberg 9.9's "Outline" block navigation dropdown.Why?
The test step came to
wp/5.7with the backport of WordPress#29920 (WordPress@6627d6a) in WordPress#30528. On trunk, that PR changed the test to select the template part from the List View sidebar, because clicking the block itself could hit the inserter between the template part's columns.wp/5.7is Gutenberg 9.9, which has no List View sidebar: its block list is a dropdown under a toolbar button labelled "Outline". The test waits forbutton[aria-label="List View"], which never appears, so it fails on every run (Admin - 4, https://github.com/desrosj/gutenberg/actions/runs/37833047536).The product change from WordPress#29920 is still correct for this branch: the double inserter it fixes came from WordPress#28418, which is in Gutenberg 9.9.
How?
button[aria-label="Outline"]instead ofbutton[aria-label="List View"], as the other 5.7 tests do (columns.test.js,block-hierarchy-navigation.test.js,reusable-blocks.test.js).Using custom components as toolbar controls is deprecatedwarning, as the earlier test in this file already does. Selecting the template part shows its block toolbar, whose text field Gutenberg 9.9 still renders as a custom toolbar control, so the console check after the test otherwise fails (Admin - 4, https://github.com/desrosj/gutenberg/actions/runs/37983431197).Only
wp/5.7is affected:wp/5.8andwp/5.9have the List View sidebar, and thewp/5.6andwp/5.5versions of this test don't use it.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code