Skip to content

Repair wp/5.7 branch Actions: Download objectFitPolyfill from jsDelivr - #685

Closed
desrosj wants to merge 1 commit into
fix-actions-5.7/fix-create-block-wp-dependenciesfrom
fix-actions-5.7/fix-object-fit-polyfill-cdn
Closed

desrosj wants to merge 1 commit into
fix-actions-5.7/fix-create-block-wp-dependenciesfrom
fix-actions-5.7/fix-object-fit-polyfill-cdn

Conversation

@desrosj

@desrosj desrosj commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

What?

Changes the objectFitPolyfill vendor script URL in lib/client-assets.php from unpkg to jsDelivr, keeping the same package, version (2.3.0) and file path.

Why?

https://unpkg.com/objectFitPolyfill@2.3.0/dist/objectFitPolyfill.min.js now returns 404 (Package not found). bin/build-plugin-zip.sh (npm run build:plugin-zip) downloads the registered vendor scripts and exits on any non-200 response, so the plugin zip for this branch can't be built at all. In development mode, gutenberg_register_vendor_script() also requests the URL at runtime and, when it can't download it, enqueues the dead URL instead.

unpkg lowercases package names since moving to Cloudflare Workers, so it can no longer serve legacy npm packages with capital letters in their names. The maintainers closed the report as not planned (unpkg/unpkg#453). The package itself is unchanged on npm.

Trunk removed the polyfill in WordPress#34536 (WordPress@351e52c) and the build-time vendor downloads in WordPress#39534 (WordPress@1639284). Neither is suitable here: this branch still supports WordPress 5.6, and WordPress#39534 rewrites the build pipeline.

How?

jsDelivr serves the same npm file (the 2.3.0 file is byte-identical to the npm tarball's). The file is still downloaded at build time and shipped in the plugin's vendor/ directory, so browsers never request it from the CDN. Only the vendor filename's hash changes; nothing references that filename directly.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj self-assigned this Oct 8, 2026
@desrosj
desrosj added this pull request to stack #672 October 8, 2026 15:14
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-object-fit-polyfill-cdn branch from 8df844f to 08dc14e Compare October 8, 2026 17:04
@desrosj
desrosj removed this pull request from stack #672 October 8, 2026 17:58
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-object-fit-polyfill-cdn branch from 08dc14e to 54d9e78 Compare October 8, 2026 17:59
@desrosj
desrosj added this pull request to stack #688 October 8, 2026 17:59
@desrosj
desrosj removed this pull request from stack #688 October 8, 2026 19:33
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-object-fit-polyfill-cdn branch from 54d9e78 to 4865192 Compare October 8, 2026 19:33
@desrosj
desrosj added this pull request to stack #693 October 8, 2026 19:34
@desrosj
desrosj removed this pull request from stack #693 October 9, 2026 14:02
@desrosj
desrosj added this pull request to stack #710 October 9, 2026 14:03
@desrosj
desrosj removed this pull request from stack #710 October 9, 2026 14:46
@desrosj
desrosj added this pull request to stack #714 October 9, 2026 14:48
@desrosj
desrosj removed this pull request from stack #714 October 9, 2026 15:13
@desrosj
desrosj added this pull request to stack #717 October 9, 2026 15:13
@desrosj
desrosj removed this pull request from stack #717 October 9, 2026 19:50
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-create-block-wp-dependencies to wp/5.7 October 9, 2026 19:51
@desrosj
desrosj force-pushed the fix-actions-5.7/fix-object-fit-polyfill-cdn branch from 4865192 to 0410116 Compare October 9, 2026 19:53
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-create-block-wp-dependencies October 9, 2026 19:55
@desrosj
desrosj added this pull request to stack #719 October 9, 2026 19:55
@desrosj
desrosj marked this pull request as ready for review October 15, 2026 02:26
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84788.

@desrosj desrosj closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant