Repository navigation
Repair wp/6.0 branch Actions: Resolve Composer dependencies against the lowest tested PHP version - #633
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #634
October 6, 2026 17:56
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
…the tests run under.
desrosj
removed this pull request from stack #634
October 7, 2026 18:02
desrosj
changed the base branch from
fix-actions-6.0/fix-phpunit-dev-dependency-floor
to
wp/6.0
October 7, 2026 18:02
desrosj
force-pushed
the
fix-actions-6.0/fix-composer-platform-override
branch
from
October 7, 2026 18:04
5b9ee37 to
777226e
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-phpunit-dev-dependency-floor
October 7, 2026 18:06
desrosj
added this pull request to stack #669
October 7, 2026 18:06
desrosj
marked this pull request as ready for review
October 8, 2026 04:23
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84282. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes Composer resolve this branch's dependencies against PHP
5.6.20, the lowest PHP version the unit-test matrix runs and WordPress's minimum PHP version for this release:composer.json'sconfig.platform.phpfrom7.4to5.6.20."php": ">=5.6.20"torequire.composer.lockwithcomposer update phpunit/phpunit --with-all-dependencies. The only package changes are:symfony/yamlv4.4.45→v3.4.47doctrine/instantiator1.5.0→1.0.5myclabs/deep-copy1.13.4→1.7.0phpdocumentor/reflection-common2.2.0→1.0.1phpdocumentor/reflection-docblock5.6.7→3.3.2phpdocumentor/type-resolver1.12.0→0.4.0phpunit/php-token-stream2.0.2→1.4.12symfony/polyfill-ctypev1.37.0→v1.19.0webmozart/assert1.12.1→1.9.1doctrine/deprecationsphpstan/phpdoc-parserThis is the
wp/6.0counterpart of #441 (wp/6.1) and #512 (wp/6.2).Why?
With the platform set to
7.4, Composer installssymfony/yaml4.4, which requires PHP 7.1. ThePHP 7.0jobs run the PHPUnit6.5phar from the wp-env image, and the plugin's Composer autoloader is registered in front of the phar's own. When PHPUnit prints a failure diff, it loadsSymfony\Component\Yaml\Yamlfrom the plugin'svendordirectory, and PHP 7.0 cannot parse it. Every failing assertion then becomes a fatal error, as in thePHP 7.0job of run 37374660162:Resolving against
5.6.20picks versions that every job in the matrix can load.How?
#441 and #512 remove
config.platform.phpentirely and let Composer detect the running PHP version. That doesn't work here. Those branches have nocomposer.lockand runcomposer installon the runner at the job's own PHP version. This branch commits acomposer.lockand installs inside wp-env'scomposercontainer, which runs PHP8.5. Without a platform value,composer installwould check the lock against PHP8.5and reject it, because PHPUnit5.7and its dependencies don't allow PHP 8. So this branch keepsconfig.platform.php, sets it to the lowest PHP version the tests run under, and adds the samerequire.phpfloor as the other branches.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code