Skip to content

Repair wp/5.6 branch Actions: Pin MariaDB to 10.5 in CI - #622

Closed
desrosj wants to merge 1 commit into
fix-actions-5.6/replace-db-check-with-healthcheckfrom
fix-actions-5.6/pin-mariadb-version
Closed

desrosj wants to merge 1 commit into
fix-actions-5.6/replace-db-check-with-healthcheckfrom
fix-actions-5.6/pin-mariadb-version

Conversation

@desrosj

@desrosj desrosj commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

What?

Pins the MariaDB version wp-env uses in this branch's CI to 10.5, by setting WP_ENV_MARIADB_VERSION: '10.5' in the workflow-level env: of end2end-test.yml and unit-test.yml.

Why?

Without a pin, wp-env runs the floating mariadb:latest image: whatever the newest MariaDB release is at the time, many years newer than anything WordPress 5.6 was released against. 10.5 is the latest MariaDB LTS release that came out before WordPress 5.6, so the database now matches that release's era.

How?

Uses the WP_ENV_MARIADB_VERSION environment variable added in #575. On this branch that is the only mechanism: wp-env has no mariadbVersion option here, and the generated Docker Compose file uses image: 'mariadb:${WP_ENV_MARIADB_VERSION:-latest}' for its single, shared mysql service. wp-env runs docker compose without overriding the environment, so the variable reaches Compose's variable substitution straight from the job environment. A workflow-level env: covers every job, including all four End-to-End jobs and every PHP matrix job.

Checked with this branch's own build-docker-compose-config.js: with WP_ENV_MARIADB_VERSION=10.5, docker compose config resolves the mysql service to mariadb:10.5 (and to mariadb:latest without it).

The other workflows (bundle-size.yml, create-block.yml, static-checks.yml) do not run wp-env.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj added this pull request to stack #557 October 6, 2026 14:32
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from 4ba321f to 37a14f9 Compare October 6, 2026 16:14
@desrosj
desrosj removed this pull request from stack #557 October 6, 2026 16:14
@desrosj
desrosj added this pull request to stack #631 October 6, 2026 16:14
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from 37a14f9 to b32d106 Compare October 7, 2026 13:03
@desrosj
desrosj removed this pull request from stack #631 October 7, 2026 18:05
@desrosj
desrosj changed the base branch from fix-actions-5.6/replace-db-check-with-healthcheck to wp/5.6 October 7, 2026 18:06
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from b32d106 to 254476c Compare October 7, 2026 18:07
@desrosj
desrosj changed the base branch from wp/5.6 to fix-actions-5.6/replace-db-check-with-healthcheck October 7, 2026 18:08
@desrosj
desrosj added this pull request to stack #670 October 7, 2026 18:08
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch 2 times, most recently from 254476c to 5b7c7d1 Compare October 8, 2026 14:28
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from 5b7c7d1 to feb97f1 Compare October 8, 2026 17:41
@desrosj
desrosj removed this pull request from stack #670 October 8, 2026 18:01
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from feb97f1 to 8f4edff Compare October 8, 2026 18:01
@desrosj
desrosj added this pull request to stack #690 October 8, 2026 18:01
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch 2 times, most recently from dbc7a7e to af53d13 Compare October 9, 2026 15:50
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from af53d13 to 80f9045 Compare October 9, 2026 15:54
@desrosj
desrosj removed this pull request from stack #690 October 9, 2026 19:56
@desrosj
desrosj changed the base branch from fix-actions-5.6/replace-db-check-with-healthcheck to wp/5.6 October 9, 2026 19:56
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from 80f9045 to fb1870d Compare October 9, 2026 19:57
@desrosj
desrosj changed the base branch from wp/5.6 to fix-actions-5.6/replace-db-check-with-healthcheck October 9, 2026 19:59
@desrosj
desrosj added this pull request to stack #721 October 9, 2026 19:59
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from fb1870d to 21d3ff2 Compare October 13, 2026 02:34
@desrosj
desrosj removed this pull request from stack #721 October 16, 2026 01:09
@desrosj
desrosj force-pushed the fix-actions-5.6/pin-mariadb-version branch from 21d3ff2 to c8ba61b Compare October 16, 2026 01:09
@desrosj
desrosj added this pull request to stack #727 October 16, 2026 01:10
@desrosj
desrosj marked this pull request as ready for review October 16, 2026 13:11
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84973.

@desrosj desrosj closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant