Repository navigation
Conversation
desrosj
added this pull request to stack #615
October 5, 2026 20:48
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
removed this pull request from stack #615
October 7, 2026 01:12
desrosj
added this pull request to stack #647
October 7, 2026 01:12
desrosj
removed this pull request from stack #647
October 7, 2026 18:05
desrosj
changed the base branch from
fix-actions-5.8/update-php-test-matrix
to
wp/5.8
October 7, 2026 18:06
desrosj
force-pushed
the
fix-actions-5.8/remove-phpunit-watcher
branch
from
October 7, 2026 18:07
a309846 to
8b42e22
Compare
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/update-php-test-matrix
October 7, 2026 18:09
desrosj
added this pull request to stack #671
October 7, 2026 18:09
desrosj
removed this pull request from stack #671
October 8, 2026 19:34
desrosj
force-pushed
the
fix-actions-5.8/remove-phpunit-watcher
branch
from
October 8, 2026 19:34
8b42e22 to
aaf7284
Compare
desrosj
added this pull request to stack #694
October 8, 2026 19:35
desrosj
removed this pull request from stack #694
October 9, 2026 13:13
desrosj
added this pull request to stack #702
October 9, 2026 13:14
desrosj
removed this pull request from stack #702
October 9, 2026 13:34
desrosj
added this pull request to stack #705
October 9, 2026 13:34
desrosj
removed this pull request from stack #705
October 9, 2026 14:01
desrosj
added this pull request to stack #708
October 9, 2026 14:02
desrosj
removed this pull request from stack #708
October 9, 2026 14:13
desrosj
added this pull request to stack #712
October 9, 2026 14:13
desrosj
marked this pull request as ready for review
October 9, 2026 17:42
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
spatie/phpunit-watcherdev dependency fromcomposer.jsonandcomposer.lock, along with the two scripts that only ran it: Composer'stest:watchand npm'stest-php:watch."test": "phpunit"stays.Why?
The package requires PHP 7.2 or newer, so the
5.6and7.0PHPUnit jobs (added in #332) can't load it.It pulls in Symfony packages whose bootstrap files Composer's autoloader always loads. A file has to parse before its own
PHP_VERSION_IDcheck can run, and these don't parse on old PHP (php -lexit codes in realphp:5.6-cliandphp:7.0-clicontainers):vendor/autoload.phpsymfony/string/Resources/functions.php255255symfony/polyfill-php80/bootstrap.php2550symfony/deprecation-contracts/function.php2550phpunit/bootstrap.phploadsvendor/autoload.phpfirst, so those jobs stop before any test runs.Removing the package in CI with
composer remove --no-updatedoesn't help: it only editscomposer.json, andcomposer installthen warns that the lock is out of date and installs from the lock anyway. So the package is removed from both files.wp/6.0does the same in WordPress#84272.How?
composer.lockwas regenerated with an update limited to this package (composer update spatie/phpunit-watcher --ignore-platform-req=php):spatie/phpunit-watcherand the packages only it needed:clue/*,evenement/evenement,jolicode/jolinotif,psr/container,react/*,yosymfony/resource-watcherand itssymfony/*packages.symfony/polyfill-ctypestays, because other packages still need it.content-hash, plusplugin-api-version2.0.0 → 2.9.0 and[]→{}forstability-flags,platformandplatform-dev, written by the current Composer.Together with #455,
composer installexits0with no lock warning, and every file invendor/composer/autoload_files.phppassesphp -lon PHP 5.6 and 7.0.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code