Skip to content

Repair wp/6.1 branch Actions: Remove the spatie/phpunit-watcher dev dependency - #607

Closed
desrosj wants to merge 1 commit into
fix-actions-6.1/update-php-test-matrixfrom
fix-actions-6.1/remove-phpunit-watcher
Closed

desrosj wants to merge 1 commit into
fix-actions-6.1/update-php-test-matrixfrom
fix-actions-6.1/remove-phpunit-watcher

Conversation

@desrosj

@desrosj desrosj commented Oct 5, 2026

Copy link
Copy Markdown
Owner

What?

Removes the spatie/phpunit-watcher dev dependency: drops it from require-dev in composer.json, drops the test:watch Composer script (keeping "test": "phpunit"), and drops the test:php:watch npm script from package.json that called it. This branch commits no composer.lock, so there is no lock to regenerate.

Why?

The PHPUnit matrix added by the PR below this one (#330) includes PHP 5.6 and 7.0 legs. spatie/phpunit-watcher pulls in symfony/polyfill-php80 through its symfony/* dependencies, and that package's bootstrap.php is a Composer files autoload entry written in PHP 7.1+ syntax. Loading vendor/autoload.php on PHP 5.6 or 7.0 is therefore a parse error before any test runs.

spatie/phpunit-watcher only backs the local composer test:watch convenience command, which CI never runs. Removing it outright fixes the crash on every matrix leg, rather than adding a workflow step that removes it from the Composer dependency set on older PHP versions only.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@desrosj
desrosj force-pushed the fix-actions-6.1/remove-phpunit-watcher branch from 88188b3 to 862c45f Compare October 6, 2026 14:20
@desrosj
desrosj removed this pull request from stack #611 October 6, 2026 14:20
@desrosj
desrosj added this pull request to stack #621 October 6, 2026 14:21
@desrosj
desrosj removed this pull request from stack #621 October 7, 2026 18:02
@desrosj
desrosj changed the base branch from fix-actions-6.1/update-php-test-matrix to wp/6.1 October 7, 2026 18:02
@desrosj
desrosj force-pushed the fix-actions-6.1/remove-phpunit-watcher branch from 862c45f to 47985dd Compare October 7, 2026 18:04
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/update-php-test-matrix October 7, 2026 18:05
@desrosj
desrosj added this pull request to stack #667 October 7, 2026 18:05
@desrosj
desrosj marked this pull request as ready for review October 8, 2026 03:27
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84249.

@desrosj desrosj closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant