Repository navigation
Repair wp/5.6 branch Actions: Replace wp-env's database check with a MariaDB health check - #597
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #557
September 30, 2026 10:38
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 5, 2026 20:44
5ba1f9c to
066744f
Compare
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 5, 2026 20:51
066744f to
82beca6
Compare
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 6, 2026 15:46
82beca6 to
50097b2
Compare
desrosj
removed this pull request from stack #557
October 6, 2026 16:14
desrosj
changed the base branch from
fix-actions-5.6/add-mariadb-version-option
to
fix-actions-5.6/create-wp-env-databases
October 6, 2026 16:14
desrosj
added this pull request to stack #631
October 6, 2026 16:14
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 7, 2026 13:03
50097b2 to
e363c80
Compare
desrosj
removed this pull request from stack #631
October 7, 2026 18:05
desrosj
changed the base branch from
fix-actions-5.6/create-wp-env-databases
to
wp/5.6
October 7, 2026 18:06
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 7, 2026 18:07
e363c80 to
5902c85
Compare
desrosj
changed the base branch from
wp/5.6
to
fix-actions-5.6/create-wp-env-databases
October 7, 2026 18:08
desrosj
added this pull request to stack #670
October 7, 2026 18:08
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 8, 2026 17:41
5902c85 to
488ffe0
Compare
desrosj
removed this pull request from stack #670
October 8, 2026 18:01
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 8, 2026 18:01
488ffe0 to
d332ff3
Compare
desrosj
added this pull request to stack #690
October 8, 2026 18:01
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 9, 2026 15:49
d332ff3 to
b701249
Compare
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
2 times, most recently
from
October 9, 2026 15:54
0a31ae7 to
f7dbfbc
Compare
desrosj
removed this pull request from stack #690
October 9, 2026 19:56
desrosj
changed the base branch from
fix-actions-5.6/create-wp-env-databases
to
wp/5.6
October 9, 2026 19:56
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 9, 2026 19:57
f7dbfbc to
1d4b0b8
Compare
desrosj
changed the base branch from
wp/5.6
to
fix-actions-5.6/create-wp-env-databases
October 9, 2026 19:59
desrosj
added this pull request to stack #721
October 9, 2026 19:59
desrosj
removed this pull request from stack #721
October 16, 2026 01:09
desrosj
force-pushed
the
fix-actions-5.6/replace-db-check-with-healthcheck
branch
from
October 16, 2026 01:09
1d4b0b8 to
ffb99b3
Compare
desrosj
added this pull request to stack #727
October 16, 2026 01:10
desrosj
marked this pull request as ready for review
October 16, 2026 13:16
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84972. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ports #75046 ("wp-env: Fix MySQL startup race condition causing database connection errors"), using #83751's health check command:
mysqlandtests-mysqlget a health check (oneMARIADB_HEALTHCHECKconstant) andMARIADB_AUTO_UPGRADE, so existing databases get the userhealthcheck.shneeds.wordpresswaits formysql, andtests-wordpressfortests-mysql, withcondition: service_healthy.wp-env startno longer runswp db check, its 30-second retry loop or the extra 4-second sleep.CHANGELOG.mdgets trunk's entry, extended for the ping fallback; the README note onwp dbwith MariaDB before 11.4 now sayswp-env startisn't affected.Why?
wp db checkrunsmariadb-checkin theclicontainer. The currentwordpress:cliimage's client (MariaDB 11.8) requires TLS, and WP-CLI passes--no-defaults, so it can't be turned off. MariaDB before 11.4 offers no TLS by default, so the check fails withTLS/SSL error: SSL is required, but the server does not support itandwp-env startstops. This branch pins MariaDB10.5(#622), so every job that startswp-envwould fail. Trunk replaced the check with a health check that doesn't use the MySQL client.How?
depends_on,startandcleanfollow WordPress#75046 hunk for hunk, adapted to this branch'scommands/start.js,commands/clean.jsandwordpress.js.start/cleanstill start onlymysqldirectly;tests-mysql(added in #628) starts throughdepends_on.The health check runs
healthcheck.sh --connect --innodb_initializedonly when the data directory has.my-healthcheck.cnfand the image hashealthcheck.sh. Otherwise it pings over TCP on127.0.0.1withmariadb-admin(the only name in 11.0+) ormysqladmin(the only name before 10.4), with-p""for the empty root password. WordPress#75046's unconditionalhealthcheck.shfails on versions the MariaDB setting can select:10.5.8and10.6.4, have no script..my-healthcheck.cnfstays in the data volume, so an older image on a volume a newer one wrote would run a missing command (exit 127).TCP rather than the Unix socket, because the temporary server that initializes a new volume answers on the socket before the real server is listening.
Testing:
/bin/shwith stubhealthcheck.sh,mariadb-adminandmysqladmin, skipped on Windows) are ported.npm run test-unit -- packages/env: 72 tests pass. (test/cli.jscan't load locally becausenodegitisn't built; unrelated.)docker compose config. The database becomeshealthyonmariadb:10.5throughhealthcheck.sh, and onmariadb:10.3through the ping fallback.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.