Skip to content

Repair wp/5.7 branch Actions: Pin MariaDB to 10.5 - #589

Closed
desrosj wants to merge 1 commit into
fix-actions-5.7/replace-db-check-with-healthcheckfrom
fix-actions-5.7/pin-mariadb-version
Closed

desrosj wants to merge 1 commit into
fix-actions-5.7/replace-db-check-with-healthcheckfrom
fix-actions-5.7/pin-mariadb-version

Conversation

@desrosj

@desrosj desrosj commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

What?

Pins the MariaDB version wp-env uses on this branch to 10.5, by setting "mariadbVersion": "10.5" in .wp-env.json.

Why?

Without a pin, wp-env runs the floating mariadb image: whatever the newest MariaDB release is at the time, many years newer than anything WordPress 5.7 was released against. 10.5 is the latest MariaDB LTS release that came out before WordPress 5.7, so the database now matches that release's era.

How?

Uses the mariadbVersion option added in #583. #596, the PR below this one, makes wp-env start work with MariaDB releases before 11.4, so the 10.5 pin starts cleanly. The value applies to both the development and tests environments.

Checked with this branch's own wp-env code: readConfig() returns mariadbVersion 10.5 for both environments, and the generated Docker Compose configuration uses mariadb:10.5 for both the mysql and tests-mysql services.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj added this pull request to stack #556 September 30, 2026 00:34
@github-actions

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 17faf98 to 07a532f Compare October 5, 2026 20:44
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 07a532f to 4204adc Compare October 5, 2026 20:47
@desrosj
desrosj removed this pull request from stack #556 October 5, 2026 20:48
@desrosj
desrosj added this pull request to stack #614 October 5, 2026 20:48
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 4204adc to df767c6 Compare October 5, 2026 21:13
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from df767c6 to f241f39 Compare October 6, 2026 17:57
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from f241f39 to 4461157 Compare October 6, 2026 18:22
@desrosj
desrosj removed this pull request from stack #614 October 7, 2026 01:24
@desrosj
desrosj added this pull request to stack #649 October 7, 2026 01:24
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 4461157 to b4a66f4 Compare October 7, 2026 13:02
@desrosj
desrosj removed this pull request from stack #649 October 7, 2026 18:05
@desrosj
desrosj changed the base branch from fix-actions-5.7/add-mariadb-version-option to wp/5.7 October 7, 2026 18:06
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from b4a66f4 to f94ad18 Compare October 7, 2026 18:07
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/add-mariadb-version-option October 7, 2026 18:09
@desrosj
desrosj added this pull request to stack #672 October 7, 2026 18:09
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from f94ad18 to de58d0b Compare October 8, 2026 17:04
@desrosj
desrosj removed this pull request from stack #672 October 8, 2026 17:58
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from de58d0b to 81623d0 Compare October 8, 2026 17:59
@desrosj
desrosj added this pull request to stack #688 October 8, 2026 17:59
@desrosj
desrosj removed this pull request from stack #688 October 8, 2026 19:33
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 81623d0 to 1602834 Compare October 8, 2026 19:33
@desrosj
desrosj added this pull request to stack #693 October 8, 2026 19:34
@desrosj
desrosj removed this pull request from stack #693 October 9, 2026 14:02
@desrosj
desrosj added this pull request to stack #710 October 9, 2026 14:03
@desrosj
desrosj removed this pull request from stack #710 October 9, 2026 14:46
@desrosj
desrosj added this pull request to stack #714 October 9, 2026 14:48
@desrosj
desrosj removed this pull request from stack #714 October 9, 2026 15:13
@desrosj
desrosj added this pull request to stack #717 October 9, 2026 15:13
@desrosj
desrosj removed this pull request from stack #717 October 9, 2026 19:50
@desrosj
desrosj changed the base branch from fix-actions-5.7/add-mariadb-version-option to wp/5.7 October 9, 2026 19:51
@desrosj
desrosj force-pushed the fix-actions-5.7/pin-mariadb-version branch from 1602834 to 2a53c8c Compare October 9, 2026 19:53
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/replace-db-check-with-healthcheck October 9, 2026 19:55
@desrosj
desrosj added this pull request to stack #719 October 9, 2026 19:55
@desrosj
desrosj marked this pull request as ready for review October 15, 2026 02:21
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84785.

@desrosj desrosj closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant