Skip to content

Repair wp/5.7 branch Actions: Add a mariadbVersion option to wp-env - #583

Closed
desrosj wants to merge 1 commit into
fix-actions-5.7/fix-puppeteer-alias-lockfile-driftfrom
fix-actions-5.7/add-mariadb-version-option
Closed

desrosj wants to merge 1 commit into
fix-actions-5.7/fix-puppeteer-alias-lockfile-driftfrom
fix-actions-5.7/add-mariadb-version-option

Conversation

@desrosj

@desrosj desrosj commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

What?

Adds a mariadbVersion option to .wp-env.json and a WP_ENV_MARIADB_VERSION environment variable for choosing the MariaDB version wp-env runs.

  • It can be set at the top level or per environment, like phpVersion. The environment variable overrides both.
  • It accepts "lts", "latest", or a numeric version such as "10.11". Anything else fails validation.
  • Unset, the image stays mariadb, exactly as before.

The README documents the option, including the need to run wp-env destroy before switching to a lower version, and the CHANGELOG gets an entry.

Why?

This branch's wp-env always runs the floating mariadb image, which is now years newer than anything this branch was tested against. There's no way to pin an era-appropriate version.

How?

This follows #83751, which adds the same option on trunk, adapted to how phpVersion works in this branch's config code. New tests cover parsing, the environment variable override, validation and the resulting image. All 78 packages/env tests pass.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj
desrosj added this pull request to stack #556 September 29, 2026 13:24
@github-actions

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 4dbc13a to 8720776 Compare October 5, 2026 20:44
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 8720776 to 79b07e8 Compare October 5, 2026 20:47
@desrosj
desrosj removed this pull request from stack #556 October 5, 2026 20:48
@desrosj
desrosj added this pull request to stack #614 October 5, 2026 20:48
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch 2 times, most recently from 4266316 to a35c880 Compare October 6, 2026 17:57
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from a35c880 to 71ca4ca Compare October 6, 2026 18:22
@desrosj
desrosj removed this pull request from stack #614 October 7, 2026 01:24
@desrosj
desrosj added this pull request to stack #649 October 7, 2026 01:24
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 71ca4ca to a915fc3 Compare October 7, 2026 13:02
@desrosj
desrosj removed this pull request from stack #649 October 7, 2026 18:05
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-react-native-screens-git-dependency to wp/5.7 October 7, 2026 18:06
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from a915fc3 to 2bd6ecc Compare October 7, 2026 18:07
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-react-native-screens-git-dependency October 7, 2026 18:09
@desrosj
desrosj added this pull request to stack #672 October 7, 2026 18:09
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 2bd6ecc to 2db6b41 Compare October 8, 2026 17:04
@desrosj
desrosj removed this pull request from stack #672 October 8, 2026 17:58
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 2db6b41 to f93fa75 Compare October 8, 2026 17:59
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-react-native-screens-git-dependency to fix-actions-5.7/fix-puppeteer-alias-lockfile-drift October 8, 2026 17:59
@desrosj
desrosj added this pull request to stack #688 October 8, 2026 17:59
@desrosj
desrosj removed this pull request from stack #688 October 8, 2026 19:33
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from f93fa75 to 1bdd013 Compare October 8, 2026 19:33
@desrosj
desrosj added this pull request to stack #693 October 8, 2026 19:34
@desrosj
desrosj removed this pull request from stack #693 October 9, 2026 14:02
@desrosj
desrosj added this pull request to stack #710 October 9, 2026 14:03
@desrosj
desrosj removed this pull request from stack #710 October 9, 2026 14:46
@desrosj
desrosj added this pull request to stack #714 October 9, 2026 14:48
@desrosj
desrosj removed this pull request from stack #714 October 9, 2026 15:13
@desrosj
desrosj added this pull request to stack #717 October 9, 2026 15:13
@desrosj
desrosj removed this pull request from stack #717 October 9, 2026 19:50
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-puppeteer-alias-lockfile-drift to wp/5.7 October 9, 2026 19:51
@desrosj
desrosj force-pushed the fix-actions-5.7/add-mariadb-version-option branch from 1bdd013 to 67909f7 Compare October 9, 2026 19:53
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-puppeteer-alias-lockfile-drift October 9, 2026 19:55
@desrosj
desrosj added this pull request to stack #719 October 9, 2026 19:55
@desrosj
desrosj marked this pull request as ready for review October 15, 2026 02:33
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84783.

@desrosj desrosj closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant