Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
added this pull request to stack #492
September 29, 2026 13:21
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
3 times, most recently
from
October 6, 2026 14:34
c4fd689 to
6be70ff
Compare
desrosj
removed this pull request from stack #492
October 7, 2026 01:38
desrosj
added this pull request to stack #657
October 7, 2026 01:39
desrosj
removed this pull request from stack #657
October 19, 2026 17:56
desrosj
changed the base branch from
fix-actions-5.4/docker-compose-v2
to
wp/5.4
October 19, 2026 17:56
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 19, 2026 17:57
6be70ff to
081af1c
Compare
desrosj
changed the base branch from
wp/5.4
to
fix-actions-5.4/docker-compose-v2
October 19, 2026 17:57
desrosj
added this pull request to stack #743
October 19, 2026 17:57
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 19, 2026 19:14
081af1c to
ac3e21e
Compare
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
3 times, most recently
from
October 19, 2026 19:29
dc4b22f to
4ba8d72
Compare
desrosj
removed this pull request from stack #743
October 19, 2026 19:38
desrosj
changed the base branch from
fix-actions-5.4/docker-compose-v2
to
wp/5.4
October 19, 2026 19:38
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 19, 2026 19:38
4ba8d72 to
1724c1c
Compare
desrosj
changed the base branch from
wp/5.4
to
fix-actions-5.4/docker-compose-v2
October 19, 2026 19:39
desrosj
added this pull request to stack #756
October 19, 2026 19:39
desrosj
marked this pull request as ready for review
October 20, 2026 17:13
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 20, 2026 17:21
1724c1c to
6e8e0ff
Compare
desrosj
removed this pull request from stack #756
October 20, 2026 19:27
desrosj
changed the base branch from
fix-actions-5.4/docker-compose-v2
to
wp/5.4
October 20, 2026 19:27
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 20, 2026 19:28
6e8e0ff to
b65b65f
Compare
desrosj
changed the base branch from
wp/5.4
to
fix-actions-5.4/docker-compose-v2
October 20, 2026 19:29
desrosj
added this pull request to stack #802
October 20, 2026 19:29
desrosj
removed this pull request from stack #802
October 20, 2026 23:44
desrosj
changed the base branch from
fix-actions-5.4/docker-compose-v2
to
wp/5.4
October 20, 2026 23:45
desrosj
force-pushed
the
fix-actions-5.4/add-mariadb-version-option
branch
from
October 20, 2026 23:46
b65b65f to
64ab661
Compare
desrosj
changed the base branch from
wp/5.4
to
fix-actions-5.4/docker-compose-v2
October 20, 2026 23:52
desrosj
added this pull request to stack #817
October 20, 2026 23:52
desrosj
removed this pull request from stack #817
October 21, 2026 12:58
desrosj
added this pull request to stack #833
October 21, 2026 12:59
desrosj
removed this pull request from stack #833
October 21, 2026 20:45
desrosj
added this pull request to stack #845
October 21, 2026 20:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a
WP_ENV_MARIADB_VERSIONenvironment variable that chooses the MariaDB versionwp-envuses. The database image inpackages/env/lib/build-docker-compose-config.jschanges from'mariadb'to'mariadb:${WP_ENV_MARIADB_VERSION:-latest}'. When the variable isn't set, the image resolves tomariadb:latest, the same image as before.The README gets a note next to the existing port-variable note. Besides the variable, it says that MariaDB cannot start on a database written by a newer version, so before switching to a lower version, run
wp-env stop, sowp-env startcreates a new, empty database. (This branch has nowp-env destroycommand;stopis enough because the database is kept in an unnamed Docker volume that a new container does not reuse.) It also says that with a version older than 11.4,wp dbcommands in thecliandtests-clicontainers fail andwp-env cleanleaves the database as it is: the MariaDB client in thewordpress:cliimage requires TLS, and MariaDB servers before 11.4 do not offer it. WordPress itself is not affected.packages/env/CHANGELOG.mdgets an entry under the## Master→ New Feature list.Why?
This branch's
wp-env(1.0.1) always runs the floatingmariadbimage, which today is a MariaDB release many years newer than anything this branch was tested against. There is currently no way to pin an older, era-appropriate version for testing.How?
This follows #83751, which adds a
mariadbVersionoption andWP_ENV_MARIADB_VERSIONenvironment variable totrunk.wp-env1.0.1 has no version settings to extend, so only the environment variable is ported. Docker Compose fills it in when it reads the generateddocker-compose.yml, the same way this file already usesWP_ENV_PORT/WP_ENV_TESTS_PORTin the port mappings.This branch's
wp-envruns onemysqlservice for both the development and tests environments, so a single image line changes.This branch has no tests for the compose builder.
npm run test-unit -- packages/envstill passes all 22 tests locally. (packages/env/test/cli.jscouldn't load locally becausenodegit's native module wasn't built; that's unrelated to this change.)Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.