Skip to content

Repair wp/5.5 branch Actions: Add a WP_ENV_MARIADB_VERSION environment variable - #576

Closed
desrosj wants to merge 1 commit into
fix-actions-5.5/fix-bundle-size-node-versionfrom
fix-actions-5.5/add-mariadb-version-option
Closed

desrosj wants to merge 1 commit into
fix-actions-5.5/fix-bundle-size-node-versionfrom
fix-actions-5.5/add-mariadb-version-option

Conversation

@desrosj

@desrosj desrosj commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

What?

Adds a WP_ENV_MARIADB_VERSION environment variable that picks the MariaDB image wp-env uses: packages/env/lib/build-docker-compose-config.js changes 'mariadb' to 'mariadb:${WP_ENV_MARIADB_VERSION:-latest}', so the default image doesn't change.

  • README: documents the variable next to the port variables. Downgrading needs wp-env destroy, since MariaDB can't start on a database written by a newer version. With a version older than 11.4, wp db commands in the cli and tests-cli containers fail and wp-env clean leaves the database alone, because the wordpress:cli image's MariaDB client requires TLS; WordPress itself isn't affected.
  • CHANGELOG: a New Features entry.
  • Test: a new case in packages/env/test/build-docker-compose-config.js checks the image string.

Why?

This branch's wp-env (1.6.0) always runs the floating mariadb image, many years newer than anything this branch was tested against, with no way to pin an older one.

How?

Follows WordPress#83751, which adds a mariadbVersion option and this environment variable to trunk. wp-env 1.6.0 has no version settings to extend, so only the variable is ported. Docker Compose substitutes it when it reads the generated file, as it already does for WP_ENV_PORT and LOCAL_PHP.

npm run test-unit -- packages/env passes all 31 tests locally (packages/env/test/cli.js can't load without a built nodegit, which is unrelated).

The mariadb-check TLS error wp-env start hits with older MariaDB versions is fixed by #598, two PRs above.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

🤖 PR meta 🤖

🏷️ Labels

This pull request needs exactly one label indicating its type, and has 0.

  • Required: any label starting with [Type].
  • Found: none.

Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you.

@desrosj
desrosj added this pull request to stack #558 September 29, 2026 13:21
@desrosj
desrosj force-pushed the fix-actions-5.5/add-mariadb-version-option branch 2 times, most recently from 1c7dfc4 to 5979ee7 Compare October 5, 2026 20:51
@desrosj
desrosj removed this pull request from stack #558 October 6, 2026 16:14
@desrosj
desrosj added this pull request to stack #632 October 6, 2026 16:15
@desrosj
desrosj force-pushed the fix-actions-5.5/add-mariadb-version-option branch from 5979ee7 to 28fe45a Compare October 8, 2026 18:08
@desrosj
desrosj removed this pull request from stack #632 October 8, 2026 18:10
@desrosj
desrosj force-pushed the fix-actions-5.5/add-mariadb-version-option branch from 28fe45a to 7a9f7f8 Compare October 8, 2026 18:11
@desrosj
desrosj added this pull request to stack #692 October 8, 2026 18:11
@desrosj
desrosj removed this pull request from stack #692 October 9, 2026 19:59
@desrosj
desrosj changed the base branch from fix-actions-5.5/fix-bundle-size-node-version to wp/5.5 October 9, 2026 20:00
@desrosj
desrosj force-pushed the fix-actions-5.5/add-mariadb-version-option branch from 7a9f7f8 to 8498ec5 Compare October 9, 2026 20:01
@desrosj
desrosj changed the base branch from wp/5.5 to fix-actions-5.5/fix-bundle-size-node-version October 9, 2026 20:02
@desrosj
desrosj added this pull request to stack #723 October 9, 2026 20:02
@desrosj
desrosj marked this pull request as ready for review October 16, 2026 17:23
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #723 October 16, 2026 17:36
@desrosj
desrosj added this pull request to stack #739 October 16, 2026 17:36
@desrosj
desrosj force-pushed the fix-actions-5.5/add-mariadb-version-option branch from 8498ec5 to 19524a8 Compare October 16, 2026 17:47
@desrosj

desrosj commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#85008.

@desrosj desrosj closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant