Repository navigation
Repair wp/5.6 branch Actions: Add a WP_ENV_MARIADB_VERSION environment variable - #575
Closed
desrosj wants to merge 1 commit into
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
added this pull request to stack #557
September 29, 2026 13:20
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
2 times, most recently
from
October 5, 2026 20:51
dc6ec72 to
a4c6d11
Compare
desrosj
removed this pull request from stack #557
October 6, 2026 16:14
desrosj
added this pull request to stack #631
October 6, 2026 16:14
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 7, 2026 13:03
a4c6d11 to
e0343e4
Compare
desrosj
removed this pull request from stack #631
October 7, 2026 18:05
desrosj
changed the base branch from
fix-actions-5.6/fix-react-native-screens-git-dependency
to
wp/5.6
October 7, 2026 18:06
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 7, 2026 18:07
e0343e4 to
915aa5f
Compare
desrosj
changed the base branch from
wp/5.6
to
fix-actions-5.6/fix-react-native-screens-git-dependency
October 7, 2026 18:08
desrosj
added this pull request to stack #670
October 7, 2026 18:08
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 8, 2026 17:41
915aa5f to
7ddd2fe
Compare
desrosj
removed this pull request from stack #670
October 8, 2026 18:01
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 8, 2026 18:01
7ddd2fe to
524ac65
Compare
desrosj
changed the base branch from
fix-actions-5.6/fix-react-native-screens-git-dependency
to
fix-actions-5.6/fix-puppeteer-alias-lockfile-drift
October 8, 2026 18:01
desrosj
added this pull request to stack #690
October 8, 2026 18:01
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
2 times, most recently
from
October 9, 2026 15:50
6d6d57b to
40f6583
Compare
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 9, 2026 15:54
40f6583 to
788d5e2
Compare
desrosj
removed this pull request from stack #690
October 9, 2026 19:56
desrosj
changed the base branch from
fix-actions-5.6/fix-puppeteer-alias-lockfile-drift
to
wp/5.6
October 9, 2026 19:56
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 9, 2026 19:57
788d5e2 to
fcc0d72
Compare
desrosj
changed the base branch from
wp/5.6
to
fix-actions-5.6/fix-puppeteer-alias-lockfile-drift
October 9, 2026 19:59
desrosj
added this pull request to stack #721
October 9, 2026 19:59
desrosj
removed this pull request from stack #721
October 16, 2026 01:09
desrosj
force-pushed
the
fix-actions-5.6/add-mariadb-version-option
branch
from
October 16, 2026 01:09
fcc0d72 to
0a2014b
Compare
desrosj
added this pull request to stack #727
October 16, 2026 01:10
desrosj
marked this pull request as ready for review
October 16, 2026 14:14
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84970. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a
WP_ENV_MARIADB_VERSIONenvironment variable that chooses the MariaDB versionwp-envuses. The database image inpackages/env/lib/build-docker-compose-config.jschanges from'mariadb'to'mariadb:${WP_ENV_MARIADB_VERSION:-latest}'. When the variable isn't set, the image resolves tomariadb:latest, the same image as before.The README gets a note next to the existing port-variable note. Besides the variable, it says that MariaDB cannot start on a database written by a newer version, so before switching to a lower version, run
wp-env destroy, which removes the environment's Docker containers, volumes, networks, and local files, not only the database. It also says that with a version older than 11.4,wp dbcommands in thecliandtests-clicontainers fail andwp-env cleanleaves the database as it is: the MariaDB client in thewordpress:cliimage requires TLS, and MariaDB servers before 11.4 do not offer it. WordPress itself is not affected.packages/env/CHANGELOG.mdgets an entry under Unreleased → New Features.Why?
This branch's
wp-env(2.1.0) always runs the floatingmariadbimage, which today is a MariaDB release many years newer than anything this branch was tested against. There is currently no way to pin an older, era-appropriate version for testing.How?
This follows #83751, which adds a
mariadbVersionoption andWP_ENV_MARIADB_VERSIONenvironment variable totrunk.wp-env2.1.0 has no version settings to extend, so only the environment variable is ported. Docker Compose fills it in when it reads the generateddocker-compose.yml, the same way this file already usesWP_ENV_PORT/WP_ENV_TESTS_PORTin the port mappings andLOCAL_PHPin thephpunitimage.This branch's
wp-envruns onemysqlservice for both the development and tests environments, so a single image line changes.A new test in
packages/env/test/build-docker-compose-config.jschecks the generated image string.npm run test-unit -- packages/envpasses all 63 tests locally. (packages/env/test/cli.jscouldn't load locally becausenodegit's native module wasn't built; that's unrelated to this change.)Pinning the version doesn't by itself fix the
mariadb-checkTLS error thatwp-env startcan hit on this branch; that is a separate problem.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.