Repository navigation
Conversation
desrosj
added this pull request to stack #458
September 22, 2026 19:35
`actions/setup-node`'s `package-manager-cache` input defaults to `true`, so caching can switch on implicitly -- it engages as soon as `package.json` gains a `packageManager` (or `devEngines.packageManager`) field naming npm. Relying on that field's absence leaves the caching behaviour of release workflows dependent on unrelated packaging metadata. Every `actions/setup-node` step in the workflows that build and publish release artifacts now sets `package-manager-cache: false` explicitly, and the `build` job's `cache: npm` is dropped where present. Cache poisoning is an attack in which a release workflow picks up build state cached by an earlier, less-trusted run. These jobs now always install from the lockfile, so a poisoned cache cannot reach a published plugin ZIP or npm package. Ports WordPress#79835, "Disable caching when publishing built assets", adapted: upstream routes these jobs through the composite `.github/setup-node` action and passes `cache: false`; this branch calls `actions/setup-node` directly, so the equivalent input is set on each step instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
desrosj
removed this pull request from stack #458
September 22, 2026 20:15
desrosj
changed the base branch from
fix-actions-6.4/exclude-firefox-playwright-crash
to
wp/6.4
September 22, 2026 21:29
desrosj
force-pushed
the
fix-actions-6.4/disable-cache-for-release-builds
branch
from
September 22, 2026 21:30
c260b79 to
7fd47de
Compare
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/remove-rn-workflows
September 22, 2026 21:33
desrosj
added this pull request to stack #482
September 22, 2026 21:34
desrosj
removed this pull request from stack #482
September 23, 2026 01:30
desrosj
changed the base branch from
fix-actions-6.4/remove-rn-workflows
to
wp/6.4
September 23, 2026 01:30
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/remove-rn-workflows
September 23, 2026 01:37
desrosj
added this pull request to stack #485
September 23, 2026 01:38
desrosj
removed this pull request from stack #485
September 24, 2026 04:44
desrosj
changed the base branch from
fix-actions-6.4/remove-rn-workflows
to
wp/6.4
September 24, 2026 04:45
desrosj
changed the base branch from
wp/6.4
to
fix-actions-6.4/remove-rn-workflows
September 24, 2026 04:47
desrosj
added this pull request to stack #508
September 24, 2026 04:48
desrosj
removed this pull request from stack #508
September 24, 2026 17:43
desrosj
added this pull request to stack #514
September 24, 2026 17:44
desrosj
marked this pull request as ready for review
September 25, 2026 16:45
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #514
September 25, 2026 17:16
desrosj
added this pull request to stack #533
September 25, 2026 17:16
desrosj
removed this pull request from stack #533
September 28, 2026 15:23
desrosj
added this pull request to stack #550
September 28, 2026 15:24
desrosj
removed this pull request from stack #550
September 28, 2026 16:24
desrosj
added this pull request to stack #555
September 28, 2026 16:25
desrosj
removed this pull request from stack #555
September 28, 2026 18:59
desrosj
added this pull request to stack #565
September 28, 2026 19:01
Owner
Author
|
Moved to WordPress#83668. The branch is left in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the
wp/6.4branch Actions repair.What?
Sets
package-manager-cache: falseexplicitly on everyactions/setup-nodestep in the workflows that build and publish release artifacts on this branch (4 steps), and removes thebuildjob'scache: npm.build-plugin-zip.ymlbuildbuild-plugin-zip.ymlnpm-publishpublish-npm-packages.ymlreleasepublish-npm-packages.ymlreleaseWhy?
Cache poisoning is an attack in which a release workflow picks up build state cached by an earlier, less-trusted workflow run. A job that produces a published plugin ZIP or npm package should install from the lockfile every time.
actions/setup-node'spackage-manager-cacheinput defaults totrue. It currently engages only whenpackage.jsondeclarespackageManager(ordevEngines.packageManager) naming npm — which this branch does not. That means these jobs are uncached by accident, not by intent: adding that field later would silently switch caching back on in the release path with no visible change to any workflow file. Stating it explicitly removes that dependency on unrelated packaging metadata.How?
Ports WordPress/gutenberg#79835, "Disable caching when publishing built assets", adapted for this branch. Upstream routes these jobs through the composite
.github/setup-nodeaction and threads a newcacheinput through to.github/setup-npm; this branch has nosetup-npmcomposite and its release jobs callactions/setup-nodedirectly, so the equivalent input is set on each step instead.The composite
.github/setup-nodeon this branch is deliberately left alone: it is only ever called by test and automation workflows, none of which publish a release artifact.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code