Repository navigation
Repair wp/6.0 branch Actions: ignore empty PHP files in the PHP coding standards scan - #361
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #329
September 15, 2026 04:41
desrosj
removed this pull request from stack #329
September 21, 2026 18:46
desrosj
changed the base branch from
fix-actions-6.0/update-php-test-matrix
to
wp/6.0
September 21, 2026 18:47
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 21, 2026 18:52
ac25901 to
63530ce
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/update-php-test-matrix
September 21, 2026 18:54
desrosj
added this pull request to stack #404
September 21, 2026 18:54
desrosj
removed this pull request from stack #404
September 21, 2026 19:38
desrosj
changed the base branch from
fix-actions-6.0/update-php-test-matrix
to
wp/6.0
September 21, 2026 19:39
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 21, 2026 19:42
63530ce to
8ebbcf0
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/update-php-test-matrix
September 21, 2026 19:45
desrosj
added this pull request to stack #418
September 21, 2026 19:45
desrosj
removed this pull request from stack #418
September 21, 2026 21:52
desrosj
changed the base branch from
fix-actions-6.0/update-php-test-matrix
to
wp/6.0
September 21, 2026 21:53
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 21, 2026 21:55
8ebbcf0 to
c850647
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/update-php-test-matrix
September 21, 2026 21:56
desrosj
added this pull request to stack #429
September 21, 2026 21:57
desrosj
removed this pull request from stack #429
September 21, 2026 23:49
desrosj
changed the base branch from
fix-actions-6.0/update-php-test-matrix
to
wp/6.0
September 21, 2026 23:50
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/update-php-test-matrix
September 21, 2026 23:52
desrosj
added this pull request to stack #438
September 21, 2026 23:52
desrosj
removed this pull request from stack #438
September 22, 2026 15:57
desrosj
changed the base branch from
fix-actions-6.0/update-php-test-matrix
to
wp/6.0
September 22, 2026 15:58
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 22, 2026 16:00
c850647 to
55e9cf9
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-playwright-noble-install
September 22, 2026 16:01
desrosj
added this pull request to stack #462
September 22, 2026 16:02
desrosj
removed this pull request from stack #462
September 22, 2026 20:44
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-playwright-noble-install
September 23, 2026 21:29
desrosj
added this pull request to stack #502
September 23, 2026 21:30
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 24, 2026 00:38
d0e6771 to
3ffa979
Compare
desrosj
changed the title
wp/6.0 branch Actions: fix PHP lint step crashing under a current PHP releasewp/6.0 branch Actions: ignore empty PHP files in the PHP coding standards scan
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 24, 2026 02:44
3ffa979 to
b0eabca
Compare
desrosj
restored the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
September 24, 2026 04:42
desrosj
removed this pull request from stack #502
September 24, 2026 18:18
desrosj
changed the base branch from
fix-actions-6.0/fix-playwright-noble-install
to
wp/6.0
September 24, 2026 18:18
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 24, 2026 18:18
b0eabca to
1a7d78a
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-playwright-noble-install
September 24, 2026 18:19
desrosj
added this pull request to stack #522
September 24, 2026 18:19
desrosj
removed this pull request from stack #522
September 28, 2026 14:36
desrosj
changed the base branch from
fix-actions-6.0/fix-playwright-noble-install
to
wp/6.0
September 28, 2026 14:36
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 28, 2026 14:37
1a7d78a to
504cd4d
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-activate-theme-navigation-race
September 28, 2026 14:38
desrosj
added this pull request to stack #543
September 28, 2026 14:38
desrosj
removed this pull request from stack #543
September 28, 2026 19:11
desrosj
changed the base branch from
fix-actions-6.0/fix-activate-theme-navigation-race
to
wp/6.0
September 28, 2026 19:11
desrosj
force-pushed
the
fix-actions-6.0/fix-phpcs-php-deprecation-crash
branch
from
September 28, 2026 19:12
504cd4d to
35903c1
Compare
desrosj
changed the base branch from
wp/6.0
to
fix-actions-6.0/fix-activate-theme-navigation-race
September 28, 2026 19:12
desrosj
added this pull request to stack #569
September 28, 2026 19:12
desrosj
removed this pull request from stack #569
October 5, 2026 18:42
desrosj
added this pull request to stack #605
October 5, 2026 18:43
`packages/e2e-tests/themes/style-variations/index.php` is a deliberately empty placeholder (the standard WordPress convention for blocking a directory listing). PHP_CodeSniffer's `Internal.NoCodeFound` check flags any file containing no PHP code as a warning, and `phpcs` exits non-zero when any warning is reported, so this file alone was enough to fail the lint step even with no real errors anywhere else in the codebase. Trunk already excludes this same sniff for its equivalent test-theme fixture directory (`/test/gutenberg-test-themes/*`); this ports the same exclusion, adapted to this branch's `packages/e2e-tests/themes` path.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84278. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keeps the
Unit Tests→PHP coding standardsjob from failing on a deliberately empty placeholder file underpackages/e2e-tests/themes.Why?
packages/e2e-tests/themes/style-variations/index.phpis an intentionally empty placeholder — the standard WordPress convention for blocking a directory listing. PHP_CodeSniffer'sInternal.NoCodeFoundcheck reports any file containing no PHP code as a warning, andphpcsexits non-zero as soon as any warning is reported. That single file is therefore enough to fail the scan even when there is not one real coding-standards issue anywhere else in the codebase.How?
phpcs.xml.dist: ports trunk's existingInternal.NoCodeFoundexclusion. Trunk excludes its own test-theme fixture directory (/test/gutenberg-test-themes/*); this branch's equivalent fixture directory ispackages/e2e-tests/themes/*.Verification
Ran the
PHP coding standardsjob's exact command —phpcs --report-full --report-checkstyle=./.cache/phpcs-report.xml— at PHP 7.4 (the version that job pins), against this branch's tree with this branch's pinned Composer dependencies installed: exit code 0, 241 files scanned, no errors and no warnings.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.