Skip to content

Repair wp/5.7 branch Actions: add concurrency configuration to workflows - #248

Closed
desrosj wants to merge 1 commit into
fix-actions-5.7/fix-workflow-branch-filtersfrom
fix-actions-5.7/add-workflow-concurrency
Closed

desrosj wants to merge 1 commit into
fix-actions-5.7/fix-workflow-branch-filtersfrom
fix-actions-5.7/add-workflow-concurrency

Conversation

@desrosj

@desrosj desrosj commented Sep 11, 2026 •

Copy link
Copy Markdown
Owner

What?

Adds a concurrency: block to every relevant GitHub Actions workflow on this branch, so a stale in-progress run is cancelled automatically once a newer commit supersedes it.

The cancel.yml workflow this replaces is removed further down the stack, in #161, alongside this branch's other obsolete workflows.

Why?

Ports upstream trunk commit 7b39dd71905cb7e546857741e3d52e977ec36691, "Replace the Cancel workflow with native GitHub Action functionality" (#32016). Workflows that didn't exist yet (or had a different shape) when that commit landed were configured to match how trunk handles concurrency for them today.

Use of AI Tools

This PR was authored with the help of Claude Code.

@desrosj
desrosj added this pull request to stack #165 September 11, 2026 03:58
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from fa508be to 291ce96 Compare September 11, 2026 14:46
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from 291ce96 to a4bfdd1 Compare September 14, 2026 01:46
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from a4bfdd1 to 9863dc7 Compare September 15, 2026 19:19
@desrosj
desrosj removed this pull request from stack #165 September 21, 2026 19:17
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 September 21, 2026 19:18
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from 9863dc7 to a673ae2 Compare September 21, 2026 19:20
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-workflow-branch-filters September 21, 2026 19:21
@desrosj
desrosj added this pull request to stack #405 September 21, 2026 19:21
@desrosj
desrosj removed this pull request from stack #405 September 21, 2026 21:41
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 September 21, 2026 21:42
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from a673ae2 to fa1904b Compare September 21, 2026 21:46
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-workflow-branch-filters September 21, 2026 21:48
@desrosj
desrosj added this pull request to stack #426 September 21, 2026 21:48
@desrosj
desrosj removed this pull request from stack #426 September 22, 2026 10:32
@desrosj
desrosj added this pull request to stack #456 September 22, 2026 10:33
@desrosj
desrosj removed this pull request from stack #456 September 22, 2026 16:14
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 September 22, 2026 16:14
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from fa1904b to 94317d9 Compare September 22, 2026 16:15
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-workflow-branch-filters September 22, 2026 16:17
@desrosj
desrosj added this pull request to stack #465 September 22, 2026 16:17
@desrosj
desrosj removed this pull request from stack #465 September 22, 2026 21:23
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 September 22, 2026 21:23
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from 94317d9 to 142ac85 Compare September 22, 2026 21:25
@desrosj
desrosj added this pull request to stack #614 October 5, 2026 20:48
@desrosj
desrosj removed this pull request from stack #614 October 7, 2026 01:24
@desrosj
desrosj added this pull request to stack #649 October 7, 2026 01:24
@desrosj
desrosj removed this pull request from stack #649 October 7, 2026 18:05
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 October 7, 2026 18:06
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from df1c1d1 to b0a42a9 Compare October 7, 2026 18:07
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-workflow-branch-filters October 7, 2026 18:09
@desrosj
desrosj added this pull request to stack #672 October 7, 2026 18:09
@desrosj
desrosj removed this pull request from stack #672 October 8, 2026 17:58
@desrosj
desrosj added this pull request to stack #688 October 8, 2026 17:59
@desrosj
desrosj removed this pull request from stack #688 October 8, 2026 19:33
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from b0a42a9 to 07cae62 Compare October 8, 2026 19:33
@desrosj
desrosj added this pull request to stack #693 October 8, 2026 19:34
@desrosj
desrosj removed this pull request from stack #693 October 9, 2026 14:02
@desrosj
desrosj added this pull request to stack #710 October 9, 2026 14:03
@desrosj
desrosj removed this pull request from stack #710 October 9, 2026 14:46
@desrosj
desrosj added this pull request to stack #714 October 9, 2026 14:48
@desrosj
desrosj removed this pull request from stack #714 October 9, 2026 15:13
@desrosj
desrosj added this pull request to stack #717 October 9, 2026 15:13
Ports upstream trunk commit 7b39dd7
(WordPress@7b39dd7),
"Replace the Cancel workflow with native GitHub Action functionality (WordPress#32016)":
adds a `concurrency:` block to every relevant workflow so in-progress runs are
cancelled automatically when a newer commit supersedes them. The `cancel.yml`
workflow this replaces is removed earlier in this series, alongside the branch's
other obsolete workflows.

Workflows that didn't exist (or looked different) back when the upstream commit
landed were brought in line with how trunk configures concurrency for them today.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8
@desrosj
desrosj removed this pull request from stack #717 October 9, 2026 19:50
@desrosj
desrosj changed the base branch from fix-actions-5.7/fix-workflow-branch-filters to wp/5.7 October 9, 2026 19:50
@desrosj
desrosj force-pushed the fix-actions-5.7/add-workflow-concurrency branch from 07cae62 to 7ce72f8 Compare October 9, 2026 19:53
@desrosj
desrosj changed the base branch from wp/5.7 to fix-actions-5.7/fix-workflow-branch-filters October 9, 2026 19:54
@desrosj
desrosj added this pull request to stack #719 October 9, 2026 19:55
@desrosj
desrosj requested a balanced review from Copilot October 15, 2026 01:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Branch-name grouping allows unrelated PRs from different forks to cancel each other's checks.

1 open finding
What changed in this PR

Adds native GitHub Actions concurrency to five wp/5.7 workflows, preparing for removal of the legacy cancellation workflow in #161.

Changes:

  • Adds workflow-specific concurrency groups using PR branch names or commit hashes.
  • Enables cancellation of in-progress runs within each group.
File Description
.github/​workflows/​unit-test.yml Adds unit-test concurrency.
.github/​workflows/​static-checks.yml Adds static-check concurrency.
.github/​workflows/​end2end-test.yml Adds end-to-end test concurrency.
.github/​workflows/​create-block.yml Adds Create Block check concurrency.
.github/​workflows/​bundle-size.yml Adds bundle-size check concurrency.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/unit-test.yml
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants