Skip to content

Repair wp/6.4 branch Actions: widen push/pull_request branch filters - #240

Closed
desrosj wants to merge 2 commits into
fix-actions-6.4/remove-svn-version-debug-checkfrom
fix-actions-6.4/fix-workflow-branch-filters
Closed

desrosj wants to merge 2 commits into
fix-actions-6.4/remove-svn-version-debug-checkfrom
fix-actions-6.4/fix-workflow-branch-filters

Conversation

@desrosj

@desrosj desrosj commented Sep 11, 2026 •

Copy link
Copy Markdown
Owner

What?

Widens push: branch filters across this branch's GitHub Actions workflows so they trigger correctly on a direct push to this branch.

Why?

Ports upstream trunk's #82744, "Workflows: Refine and complete the push and pull_request branch filters", merged to trunk as 1a6c8ab43. Per that PR, pull_request: triggers are deliberately left unfiltered everywhere (so a PR gets the same checks regardless of target branch) except workflow-lint.yml, where a previous trunk-only filter is removed entirely.

Workflow Change Why
build-plugin-zip.yml Widened the push: branch filter Now matches trunk, release/X.Y, wp/X.Y, wp/latest, and wp/next, replacing the old [trunk] single-branch list with the precise pattern from upstream WordPress#82744.
create-block.yml Widened the push: branch filter Previously only triggered on trunk/wp/latest; now also triggers on release/X.Y, wp/X.Y, and wp/next, matching upstream WordPress#82744.
end2end-test.yml Widened the push: branch filter Now matches trunk, release/X.Y, wp/X.Y, wp/latest, and wp/next, replacing the old release/**/wp/** globs with the precise pattern from upstream WordPress#82744.
static-checks.yml Widened the push: branch filter Now matches trunk, release/X.Y, wp/X.Y, wp/latest, and wp/next, replacing the old release/**/wp/** globs with the precise pattern from upstream WordPress#82744.
unit-test.yml Widened the push: branch filter Now matches trunk, release/X.Y, wp/X.Y, wp/latest, and wp/next, replacing the old release/**/wp/** globs with the precise pattern from upstream WordPress#82744.
pull-request-automation.yml Removed the push trigger Its push-triggered tasks check payload.ref !== 'refs/heads/trunk' and return immediately on this branch, so nothing happens on push here. pull_request_target is untouched and still does real work (fixed-issue assignment, first-time-contributor labeling) on PRs targeting this branch.

Use of AI Tools

This PR was authored with the help of Claude Code.

@desrosj
desrosj added this pull request to stack #188 September 11, 2026 03:38
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from 5b4c7e8 to c79c75e Compare September 11, 2026 14:47
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from c79c75e to 97e5ab6 Compare September 11, 2026 16:09
@desrosj
desrosj removed this pull request from stack #188 September 13, 2026 00:46
@desrosj
desrosj added this pull request to stack #312 September 13, 2026 00:46
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from 97e5ab6 to 7b81347 Compare September 13, 2026 02:57
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from 7b81347 to 251fa9e Compare September 14, 2026 01:39
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from a29367d to f1afd40 Compare September 14, 2026 17:39
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from f1afd40 to 07f2b40 Compare September 15, 2026 19:19
@desrosj
desrosj removed this pull request from stack #312 September 21, 2026 18:37
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 September 21, 2026 18:38
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from 07f2b40 to 853c105 Compare September 21, 2026 18:46
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images September 21, 2026 18:47
@desrosj
desrosj added this pull request to stack #402 September 21, 2026 18:47
@desrosj
desrosj removed this pull request from stack #402 September 21, 2026 21:08
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 September 21, 2026 21:09
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from 853c105 to c7cf133 Compare September 21, 2026 21:12
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images September 21, 2026 21:17
@desrosj
desrosj added this pull request to stack #423 September 21, 2026 21:32
@desrosj
desrosj removed this pull request from stack #423 September 21, 2026 21:48
@desrosj
desrosj changed the base branch from fix-actions-6.4/pin-runner-images to wp/6.4 September 21, 2026 21:49
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from c7cf133 to c03e15a Compare September 21, 2026 21:52
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/pin-runner-images September 21, 2026 21:54
@desrosj
desrosj added this pull request to stack #428 September 21, 2026 21:54
@desrosj
desrosj added this pull request to stack #458 September 22, 2026 15:44
Ports upstream trunk PR WordPress#82744
(head commit 3fe3bd4 as of this writing; the PR
is still open/unmerged), "Workflows: Refine and complete the push and pull_request
branch filters":

- Narrows/widens `push:` branch filters on unit-test/end2end-test/static-checks/
  build-plugin-zip/create-block/workflow-lint (where present) to the precise
  upstream set (trunk, release/X.Y, wp/X.Y, wp/latest, wp/next), fixing workflows
  that previously never ran on a direct push to this branch.

Per the current version of that upstream PR, `pull_request:` triggers are
deliberately left unfiltered everywhere (a PR should get the same checks
regardless of which branch it targets) — the one exception upstream carves out is
`workflow-lint.yml`, where a previous trunk-only `pull_request` filter is removed
entirely rather than widened.

This supersedes this project's earlier port of an older revision of WordPress#82744, which
had added an explicit `pull_request` branch allowlist (plus a project-local
temporary `fix-actions-[0-9]+.[0-9]/**` pattern) to several files. That's been
reverted here to match the upstream author's updated approach — since
`pull_request` now stays unfiltered, the temporary project-local pattern is no
longer needed at all.
…h-triggered tasks (`add-milestone`, `first-time-contributor-account-link`) both bail out immediately outside of `trunk`, so running them here on every push does nothing.
@desrosj
desrosj removed this pull request from stack #458 September 22, 2026 20:15
@desrosj
desrosj changed the base branch from fix-actions-6.4/remove-svn-version-debug-check to wp/6.4 September 22, 2026 20:16
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-workflow-branch-filters branch from b0fb11d to 8797b19 Compare September 22, 2026 21:30
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/remove-svn-version-debug-check September 22, 2026 21:33
@desrosj
desrosj added this pull request to stack #482 September 22, 2026 21:34
@desrosj
desrosj removed this pull request from stack #482 September 23, 2026 01:30
@desrosj
desrosj changed the base branch from fix-actions-6.4/remove-svn-version-debug-check to wp/6.4 September 23, 2026 01:30
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/remove-svn-version-debug-check September 23, 2026 01:37
@desrosj
desrosj added this pull request to stack #485 September 23, 2026 01:38
@desrosj
desrosj removed this pull request from stack #485 September 24, 2026 04:44
@desrosj
desrosj changed the base branch from fix-actions-6.4/remove-svn-version-debug-check to wp/6.4 September 24, 2026 04:45
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/remove-svn-version-debug-check September 24, 2026 04:47
@desrosj
desrosj added this pull request to stack #508 September 24, 2026 04:48
@desrosj
desrosj removed this pull request from stack #508 September 24, 2026 17:43
@desrosj
desrosj added this pull request to stack #514 September 24, 2026 17:44
@desrosj
desrosj marked this pull request as ready for review September 25, 2026 16:46
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #514 September 25, 2026 17:16
@desrosj
desrosj added this pull request to stack #533 September 25, 2026 17:16
@desrosj
desrosj removed this pull request from stack #533 September 28, 2026 15:23
@desrosj
desrosj added this pull request to stack #550 September 28, 2026 15:24
@desrosj
desrosj removed this pull request from stack #550 September 28, 2026 16:24
@desrosj
desrosj added this pull request to stack #555 September 28, 2026 16:25
@desrosj
desrosj removed this pull request from stack #555 September 28, 2026 18:59
@desrosj
desrosj added this pull request to stack #565 September 28, 2026 19:01
@desrosj

desrosj commented Sep 28, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#83671. The branch is left in place.

@desrosj desrosj closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant