Repository navigation
Repair wp/7.0 branch Actions: remove SimenB/github-actions-cpu-cores dependency - #210
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
force-pushed
the
fix-actions-7.0/remove-cpu-cores-dependency
branch
from
September 11, 2026 02:20
a8b314b to
ca13b2f
Compare
desrosj
force-pushed
the
fix-actions-7.0/remove-cpu-cores-dependency
branch
from
September 11, 2026 02:34
ca13b2f to
3e48440
Compare
desrosj
added this pull request to stack #179
September 11, 2026 03:12
desrosj
force-pushed
the
fix-actions-7.0/remove-cpu-cores-dependency
branch
from
September 11, 2026 17:03
3e48440 to
9fc6e57
Compare
desrosj
marked this pull request as ready for review
September 11, 2026 18:16
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Upstream trunk removed the `SimenB/github-actions-cpu-cores` dependency in `4d02abd34c61e8bcf30399c219fdccedaf0e8a84` ("Remove dependency used for counting available CPUs (WordPress#78593)"). This third-party action was only ever used to populate a `MAXWORKERS` environment variable passed to Jest's `--maxWorkers` flag; `nproc` provides the exact same value directly from the runner without depending on an external action.
This removes the `SimenB/github-actions-cpu-cores` step (and its `id: cpu-cores`) from all three jobs in `unit-test.yml` that used it (`unit-js`, `unit-js-date`, and the currently-disabled `mobile-unit-js`), drops the `MAXWORKERS` env var each fed, and switches each corresponding `--maxWorkers="$MAXWORKERS"` invocation to `--maxWorkers="$(nproc)"` directly, matching trunk's fix.
desrosj
force-pushed
the
fix-actions-7.0/remove-cpu-cores-dependency
branch
from
September 11, 2026 18:37
9fc6e57 to
3adcd12
Compare
Owner
Author
|
Migrated to real upstream: WordPress#82804. Closing this fork PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
SimenB/github-actions-cpu-coresthird-party action dependency fromunit-test.yml, matching upstream trunk's own removal of it.Why?
Upstream trunk removed this dependency in
4d02abd34c61e8bcf30399c219fdccedaf0e8a84("Remove dependency used for counting available CPUs (WordPress#78593)"). The action was only ever used to populate aMAXWORKERSenvironment variable fed into Jest's--maxWorkersflag.nproc, run directly on the runner, provides the exact same value without depending on an external action.This branch (
wp/7.0) still had the dependency in three jobs inunit-test.yml:unit-js,unit-js-date, and the currently-disabledmobile-unit-js. Each had itsSimenB/github-actions-cpu-coresstep (andid: cpu-cores) removed, itsMAXWORKERSenv var line dropped, and its--maxWorkers="$MAXWORKERS"usage switched to--maxWorkers="$(nproc)"directly.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.