Repository navigation
Conversation
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
3 times, most recently
from
September 14, 2026 01:23
f0418a6 to
67548d7
Compare
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
September 15, 2026 19:18
67548d7 to
b8fb506
Compare
desrosj
removed this pull request from stack #173
September 21, 2026 16:56
desrosj
added this pull request to stack #395
September 21, 2026 16:56
desrosj
removed this pull request from stack #395
September 21, 2026 16:57
desrosj
added this pull request to stack #396
September 21, 2026 16:57
desrosj
removed this pull request from stack #396
September 22, 2026 16:02
desrosj
changed the base branch from
fix-actions-5.9/update-actions-to-latest
to
wp/5.9
September 22, 2026 16:02
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
September 22, 2026 16:03
b8fb506 to
266e9ad
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
September 22, 2026 16:04
desrosj
added this pull request to stack #463
September 22, 2026 16:04
desrosj
removed this pull request from stack #463
September 22, 2026 21:19
desrosj
changed the base branch from
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
to
wp/5.9
September 22, 2026 21:19
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
September 22, 2026 21:36
266e9ad to
b65042b
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
September 22, 2026 21:37
desrosj
added this pull request to stack #483
September 22, 2026 21:37
desrosj
removed this pull request from stack #483
September 23, 2026 01:33
desrosj
changed the base branch from
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
to
wp/5.9
September 23, 2026 01:33
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
September 23, 2026 01:51
b65042b to
9bb86f9
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
September 23, 2026 01:52
desrosj
added this pull request to stack #490
September 23, 2026 01:52
desrosj
removed this pull request from stack #490
September 23, 2026 21:23
desrosj
changed the base branch from
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
to
wp/5.9
September 23, 2026 21:24
desrosj
removed this pull request from stack #530
September 28, 2026 19:13
desrosj
changed the base branch from
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
to
wp/5.9
September 28, 2026 19:13
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
September 28, 2026 19:13
9bb86f9 to
f78a630
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
September 28, 2026 19:14
desrosj
added this pull request to stack #570
September 28, 2026 19:14
desrosj
removed this pull request from stack #570
October 5, 2026 20:49
desrosj
added this pull request to stack #616
October 5, 2026 20:49
desrosj
removed this pull request from stack #616
October 6, 2026 18:27
desrosj
added this pull request to stack #636
October 6, 2026 18:28
desrosj
removed this pull request from stack #636
October 7, 2026 00:58
desrosj
added this pull request to stack #643
October 7, 2026 00:59
desrosj
removed this pull request from stack #643
October 7, 2026 18:02
desrosj
changed the base branch from
fix-actions-5.9/pin-wp-env-core-version-for-performance-tests
to
wp/5.9
October 7, 2026 18:02
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
October 7, 2026 18:04
f78a630 to
e2c9bad
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/remove-mobile-unit-js-job
October 7, 2026 18:05
desrosj
added this pull request to stack #668
October 7, 2026 18:06
….yml. unit-js tested against both Node 12 and 14 via a matrix, while unit-php and mobile-unit-js each hardcoded node-version: 14 directly. This branch is frozen and will never move off the Node version pinned in .nvmrc, so testing an extra, older Node version (12) adds CI time without adding real coverage, and hardcoding the same version number in three separate places invites drift if .nvmrc is ever updated without updating every workflow in step. All three jobs now resolve their Node version from node-version-file: '.nvmrc' — a single source of truth — instead of a matrix or a hardcoded literal. # Conflicts: # .github/workflows/unit-test.yml
The checks job tested against both Node 12 and 14 via a matrix. This branch is frozen and will never move off the Node version pinned in .nvmrc, so testing an extra, older Node version adds CI time without adding real coverage. Resolves the Node version from node-version-file: '.nvmrc' instead.
The admin job's matrix combined a real, meaningful dimension (part,
splitting the e2e suite into four parallel shards) with a Node
version dimension that only ever had one value ('14'). This branch is
frozen and will never move off the Node version pinned in .nvmrc, so
the node dimension added no coverage, just an unnecessary layer of
matrix indirection.
The part dimension is preserved; the Node version now resolves from
node-version-file: '.nvmrc' directly.
The build job's matrix had exactly one Node value ('14'), matching
.nvmrc, so it provided no real coverage — only indirection. Resolves
the Node version from node-version-file: '.nvmrc' directly instead.
The check job hardcoded node-version: 14, duplicating .nvmrc's value in a second place that could silently drift from it. Resolves the Node version from node-version-file: '.nvmrc' directly instead.
The build job hardcoded node-version: 14, duplicating .nvmrc's value in a second place that could silently drift from it. Resolves the Node version from node-version-file: '.nvmrc' directly instead. # Conflicts: # .github/workflows/build-plugin-zip.yml
desrosj
removed this pull request from stack #668
October 8, 2026 19:35
desrosj
force-pushed
the
fix-actions-5.9/single-node-version-testing
branch
from
October 8, 2026 19:35
e2c9bad to
05daa39
Compare
desrosj
added this pull request to stack #695
October 8, 2026 19:35
desrosj
marked this pull request as ready for review
October 9, 2026 16:32
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84400. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes Node.js version matrices and hardcoded, duplicated Node version literals across every workflow in
.github/workflows/, replacing them withnode-version-file: '.nvmrc'on eachactions/setup-nodecall. No occurrence ofcheck-latest: truewas found anywhere in the tree, so there was nothing to remove for that part of this layer.unit-test.ymlunit-jsnode: ['12', '14']node-version-file: '.nvmrc', no matrixunit-test.ymlunit-php,mobile-unit-jsnode-version: 14node-version-file: '.nvmrc'create-block.ymlchecksnode: ['12', '14']node-version-file: '.nvmrc', no matrixend2end-test.ymladminpart: [1,2,3,4]+node: ['14']part: [1,2,3,4]only;node-version-file: '.nvmrc'bundle-size.ymlbuildnode: ['14']node-version-file: '.nvmrc', no matrixstatic-checks.yml,build-plugin-zip.ymlnode-version: 14node-version-file: '.nvmrc'This branch has no composite
.github/setup-node/action.ymlwrapper, so everyactions/setup-nodecall in every workflow file duplicated its own Node version, whether via a matrix or a hardcoded literal. All of them are updated here so.nvmrcbecomes the single source of truth, rather than only the two files (create-block.yml,unit-test.yml) that had a genuine multi-value matrix.Where a matrix combined a Node dimension with a real, non-Node dimension (
end2end-test.yml'spart), only the Node dimension was removed.This PR is based on
fix-actions-5.9/update-actions-to-latest(not directly onwp/5.9) because CI on this frozen branch needs the updatedactions/setup-node(which supportsnode-version-file) to actually run.Why?
This branch is frozen and will never move off the Node.js version pinned in
.nvmrc. Testing multiple Node versions (unit-test.yml,create-block.yml) added CI time without adding real coverage, and every place a Node version was hardcoded or matrixed instead of read from.nvmrcwas a place that version could silently drift from the one actually documented as required, without any workflow reflecting the change.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.