Repository navigation
Conversation
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
2 times, most recently
from
September 11, 2026 02:15
e4c9d0f to
a90acca
Compare
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
September 14, 2026 01:34
a90acca to
a4f442f
Compare
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
September 15, 2026 19:18
a4f442f to
a529634
Compare
desrosj
removed this pull request from stack #172
September 21, 2026 17:03
desrosj
added this pull request to stack #397
September 21, 2026 17:05
desrosj
removed this pull request from stack #397
September 22, 2026 16:04
desrosj
changed the base branch from
fix-actions-5.8/update-actions-to-latest
to
wp/5.8
September 22, 2026 16:04
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
September 22, 2026 16:06
a529634 to
32703b7
Compare
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/compare-performance-with-base-branch
September 22, 2026 16:07
desrosj
added this pull request to stack #464
September 22, 2026 16:14
desrosj
removed this pull request from stack #464
September 22, 2026 21:20
desrosj
changed the base branch from
fix-actions-5.8/compare-performance-with-base-branch
to
wp/5.8
September 22, 2026 21:20
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
September 22, 2026 21:39
32703b7 to
56d4428
Compare
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/compare-performance-with-base-branch
September 22, 2026 21:40
desrosj
added this pull request to stack #484
September 22, 2026 21:41
desrosj
removed this pull request from stack #484
September 23, 2026 01:33
desrosj
changed the base branch from
fix-actions-5.8/compare-performance-with-base-branch
to
wp/5.8
September 23, 2026 01:33
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
September 23, 2026 01:53
56d4428 to
ba8ce84
Compare
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/compare-performance-with-base-branch
September 23, 2026 01:54
desrosj
added this pull request to stack #491
September 23, 2026 01:54
desrosj
removed this pull request from stack #491
September 23, 2026 21:20
desrosj
changed the base branch from
fix-actions-5.8/compare-performance-with-base-branch
to
wp/5.8
September 23, 2026 21:22
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/compare-performance-with-base-branch
September 23, 2026 21:24
desrosj
added this pull request to stack #496
September 23, 2026 21:25
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/compare-performance-with-base-branch
September 28, 2026 19:15
desrosj
added this pull request to stack #571
September 28, 2026 19:16
desrosj
removed this pull request from stack #571
October 5, 2026 20:48
desrosj
added this pull request to stack #615
October 5, 2026 20:48
desrosj
removed this pull request from stack #615
October 7, 2026 01:12
desrosj
added this pull request to stack #647
October 7, 2026 01:12
desrosj
removed this pull request from stack #647
October 7, 2026 18:05
desrosj
changed the base branch from
fix-actions-5.8/compare-performance-with-base-branch
to
wp/5.8
October 7, 2026 18:06
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
October 7, 2026 18:07
d3469d6 to
075e696
Compare
desrosj
changed the base branch from
wp/5.8
to
fix-actions-5.8/remove-mobile-unit-js-job
October 7, 2026 18:08
desrosj
added this pull request to stack #671
October 7, 2026 18:09
…job. The `unit-js` job tested against Node `12` and `14`. `wp/5.8` is a frozen branch that will never move off the Node version pinned in `.nvmrc` (`14`), so testing an older, unsupported version adds nothing and only costs CI time. Drop the matrix entirely and let `actions/setup-node` read the version from `.nvmrc` directly, so the two stay in sync by construction instead of by convention.
The `checks` job tested against Node `12` and `14`. `wp/5.8` is a frozen branch that will never move off the Node version pinned in `.nvmrc` (`14`), so testing an older, unsupported version adds nothing and only costs CI time. Drop the matrix entirely and let `actions/setup-node` read the version from `.nvmrc` directly, so the two stay in sync by construction instead of by convention.
The `admin` job's matrix combined a `part` dimension (test-file sharding across 4 parallel jobs) with a `node: ['14']` dimension that only ever had one value. `wp/5.8` is a frozen branch that will never move off the Node version pinned in `.nvmrc` (`14`), so a version matrix dimension here was never providing coverage, only overhead. Drop the `node` dimension and let `actions/setup-node` read the version from `.nvmrc` directly, while keeping the `part` dimension that does real sharding work.
The `build` job's matrix had a single `node: ['14']` dimension. `wp/5.8` is a frozen branch that will never move off the Node version pinned in `.nvmrc` (`14`), so a version matrix here was never providing coverage. Drop the matrix entirely and let `actions/setup-node` read the version from `.nvmrc` directly.
desrosj
removed this pull request from stack #671
October 8, 2026 19:34
desrosj
force-pushed
the
fix-actions-5.8/single-node-version-testing
branch
from
October 8, 2026 19:34
075e696 to
efd06ac
Compare
desrosj
added this pull request to stack #694
October 8, 2026 19:35
desrosj
removed this pull request from stack #694
October 9, 2026 13:13
desrosj
added this pull request to stack #702
October 9, 2026 13:14
desrosj
removed this pull request from stack #702
October 9, 2026 13:34
desrosj
added this pull request to stack #705
October 9, 2026 13:34
desrosj
removed this pull request from stack #705
October 9, 2026 14:01
desrosj
added this pull request to stack #708
October 9, 2026 14:02
desrosj
removed this pull request from stack #708
October 9, 2026 14:13
desrosj
added this pull request to stack #712
October 9, 2026 14:13
desrosj
marked this pull request as ready for review
October 9, 2026 17:29
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84434. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Eliminates every Node.js version-matrix dimension across
wp/5.8's workflows, falling back to the version pinned in.nvmrc(14) instead.unit-test.ymlunit-jsnode: ['12', '14']node-version-file: '.nvmrc'create-block.ymlchecksnode: ['12', '14']node-version-file: '.nvmrc'end2end-test.ymladminpart: [1,2,3,4],node: ['14']nodedimension removed,partsharding dimension kept;node-version-file: '.nvmrc'bundle-size.ymlbuildnode: ['14']node-version-file: '.nvmrc'This branch has no
actions/setup-nodecall anywhere withcheck-latest: trueset, so there was nothing to remove for that part of this layer. The remaining hardcodednode-version: 14values inunit-test.yml(unit-php,mobile-unit-js),static-checks.yml, andbuild-plugin-zip.ymlwere left as-is — none of those had a matrix to eliminate, and14already matches.nvmrc.Why?
wp/5.8is a frozen, security-maintenance-only branch that will never move off the Node version pinned in.nvmrc. Testing against Node12in addition to14(inunit-test.ymlandcreate-block.yml) or carrying a single-valuenodematrix dimension elsewhere never provided real coverage on this branch and only cost CI time. Reading the version from.nvmrcvianode-version-filealso means the workflow and.nvmrccan't drift out of sync, since there's only one place the version is declared.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.