Skip to content

Repair wp/5.8 branch Actions: single Node.js version testing - #168

Closed
desrosj wants to merge 4 commits into
fix-actions-5.8/remove-mobile-unit-js-jobfrom
fix-actions-5.8/single-node-version-testing
Closed

desrosj wants to merge 4 commits into
fix-actions-5.8/remove-mobile-unit-js-jobfrom
fix-actions-5.8/single-node-version-testing

Conversation

@desrosj

@desrosj desrosj commented Sep 1, 2026 •

Copy link
Copy Markdown
Owner

What?

Eliminates every Node.js version-matrix dimension across wp/5.8's workflows, falling back to the version pinned in .nvmrc (14) instead.

Workflow Job Old matrix Change
unit-test.yml unit-js node: ['12', '14'] Matrix removed; node-version-file: '.nvmrc'
create-block.yml checks node: ['12', '14'] Matrix removed; node-version-file: '.nvmrc'
end2end-test.yml admin part: [1,2,3,4], node: ['14'] node dimension removed, part sharding dimension kept; node-version-file: '.nvmrc'
bundle-size.yml build node: ['14'] Matrix (its only dimension) removed entirely; node-version-file: '.nvmrc'

This branch has no actions/setup-node call anywhere with check-latest: true set, so there was nothing to remove for that part of this layer. The remaining hardcoded node-version: 14 values in unit-test.yml (unit-php, mobile-unit-js), static-checks.yml, and build-plugin-zip.yml were left as-is — none of those had a matrix to eliminate, and 14 already matches .nvmrc.

Why?

wp/5.8 is a frozen, security-maintenance-only branch that will never move off the Node version pinned in .nvmrc. Testing against Node 12 in addition to 14 (in unit-test.yml and create-block.yml) or carrying a single-value node matrix dimension elsewhere never provided real coverage on this branch and only cost CI time. Reading the version from .nvmrc via node-version-file also means the workflow and .nvmrc can't drift out of sync, since there's only one place the version is declared.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch 2 times, most recently from e4c9d0f to a90acca Compare September 11, 2026 02:15
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from a90acca to a4f442f Compare September 14, 2026 01:34
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from a4f442f to a529634 Compare September 15, 2026 19:18
@desrosj
desrosj removed this pull request from stack #172 September 21, 2026 17:03
@desrosj
desrosj added this pull request to stack #397 September 21, 2026 17:05
@desrosj
desrosj removed this pull request from stack #397 September 22, 2026 16:04
@desrosj
desrosj changed the base branch from fix-actions-5.8/update-actions-to-latest to wp/5.8 September 22, 2026 16:04
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from a529634 to 32703b7 Compare September 22, 2026 16:06
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/compare-performance-with-base-branch September 22, 2026 16:07
@desrosj
desrosj added this pull request to stack #464 September 22, 2026 16:14
@desrosj
desrosj removed this pull request from stack #464 September 22, 2026 21:20
@desrosj
desrosj changed the base branch from fix-actions-5.8/compare-performance-with-base-branch to wp/5.8 September 22, 2026 21:20
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from 32703b7 to 56d4428 Compare September 22, 2026 21:39
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/compare-performance-with-base-branch September 22, 2026 21:40
@desrosj
desrosj added this pull request to stack #484 September 22, 2026 21:41
@desrosj
desrosj removed this pull request from stack #484 September 23, 2026 01:33
@desrosj
desrosj changed the base branch from fix-actions-5.8/compare-performance-with-base-branch to wp/5.8 September 23, 2026 01:33
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from 56d4428 to ba8ce84 Compare September 23, 2026 01:53
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/compare-performance-with-base-branch September 23, 2026 01:54
@desrosj
desrosj added this pull request to stack #491 September 23, 2026 01:54
@desrosj
desrosj removed this pull request from stack #491 September 23, 2026 21:20
@desrosj
desrosj changed the base branch from fix-actions-5.8/compare-performance-with-base-branch to wp/5.8 September 23, 2026 21:22
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/compare-performance-with-base-branch September 23, 2026 21:24
@desrosj
desrosj added this pull request to stack #496 September 23, 2026 21:25
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/compare-performance-with-base-branch September 28, 2026 19:15
@desrosj
desrosj added this pull request to stack #571 September 28, 2026 19:16
@desrosj
desrosj removed this pull request from stack #571 October 5, 2026 20:48
@desrosj
desrosj added this pull request to stack #615 October 5, 2026 20:48
@desrosj
desrosj removed this pull request from stack #615 October 7, 2026 01:12
@desrosj
desrosj added this pull request to stack #647 October 7, 2026 01:12
@desrosj
desrosj removed this pull request from stack #647 October 7, 2026 18:05
@desrosj
desrosj changed the base branch from fix-actions-5.8/compare-performance-with-base-branch to wp/5.8 October 7, 2026 18:06
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from d3469d6 to 075e696 Compare October 7, 2026 18:07
@desrosj
desrosj changed the base branch from wp/5.8 to fix-actions-5.8/remove-mobile-unit-js-job October 7, 2026 18:08
@desrosj
desrosj added this pull request to stack #671 October 7, 2026 18:09
…job.

The `unit-js` job tested against Node `12` and `14`. `wp/5.8` is a
frozen branch that will never move off the Node version pinned in
`.nvmrc` (`14`), so testing an older, unsupported version adds nothing
and only costs CI time. Drop the matrix entirely and let
`actions/setup-node` read the version from `.nvmrc` directly, so the
two stay in sync by construction instead of by convention.
The `checks` job tested against Node `12` and `14`. `wp/5.8` is a
frozen branch that will never move off the Node version pinned in
`.nvmrc` (`14`), so testing an older, unsupported version adds nothing
and only costs CI time. Drop the matrix entirely and let
`actions/setup-node` read the version from `.nvmrc` directly, so the
two stay in sync by construction instead of by convention.
The `admin` job's matrix combined a `part` dimension (test-file
sharding across 4 parallel jobs) with a `node: ['14']` dimension that
only ever had one value. `wp/5.8` is a frozen branch that will never
move off the Node version pinned in `.nvmrc` (`14`), so a version
matrix dimension here was never providing coverage, only overhead.
Drop the `node` dimension and let `actions/setup-node` read the
version from `.nvmrc` directly, while keeping the `part` dimension
that does real sharding work.
The `build` job's matrix had a single `node: ['14']` dimension. `wp/5.8`
is a frozen branch that will never move off the Node version pinned
in `.nvmrc` (`14`), so a version matrix here was never providing
coverage. Drop the matrix entirely and let `actions/setup-node` read
the version from `.nvmrc` directly.
@desrosj
desrosj removed this pull request from stack #671 October 8, 2026 19:34
@desrosj
desrosj force-pushed the fix-actions-5.8/single-node-version-testing branch from 075e696 to efd06ac Compare October 8, 2026 19:34
@desrosj
desrosj added this pull request to stack #694 October 8, 2026 19:35
@desrosj
desrosj removed this pull request from stack #694 October 9, 2026 13:13
@desrosj
desrosj added this pull request to stack #702 October 9, 2026 13:14
@desrosj
desrosj removed this pull request from stack #702 October 9, 2026 13:34
@desrosj
desrosj added this pull request to stack #705 October 9, 2026 13:34
@desrosj
desrosj removed this pull request from stack #705 October 9, 2026 14:01
@desrosj
desrosj added this pull request to stack #708 October 9, 2026 14:02
@desrosj
desrosj removed this pull request from stack #708 October 9, 2026 14:13
@desrosj
desrosj added this pull request to stack #712 October 9, 2026 14:13
@desrosj
desrosj marked this pull request as ready for review October 9, 2026 17:29
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84434.

@desrosj desrosj closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant