Repository navigation
Conversation
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 1, 2026 14:05
df0b543 to
6140ecb
Compare
|
Flaky tests detected in 74cf291. 🔍 Workflow run URL: https://github.com/desrosj/gutenberg/actions/runs/34634440160 post title and content are editable and blocks can be inserted in
|
desrosj
removed this pull request from stack #151
September 10, 2026 18:21
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 10, 2026 18:22
6140ecb to
747dda1
Compare
desrosj
added this pull request to stack #179
September 10, 2026 18:22
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 10, 2026 18:40
747dda1 to
8678dac
Compare
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 10, 2026 20:08
8678dac to
930dd6d
Compare
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
2 times, most recently
from
September 11, 2026 00:27
fab0fd0 to
e8f3bcc
Compare
desrosj
marked this pull request as ready for review
September 11, 2026 01:09
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
3 times, most recently
from
September 11, 2026 02:33
ce3490f to
13a34b3
Compare
desrosj
marked this pull request as draft
September 11, 2026 03:21
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 11, 2026 17:03
13a34b3 to
73842ac
Compare
desrosj
marked this pull request as ready for review
September 11, 2026 18:21
`check-latest: true` re-checks the npm registry for a newer Node.js release matching the requested version range on every run. On this frozen branch the requested version is fixed by `.nvmrc` and will never move, so the check only adds a wasted network round trip and a theoretical (if remote) risk of picking up an unpinned point release mid-run.
This removes the `node` matrix dimension (and its now-unused `event`-based exclude entries) from the `checks` job in `create-block.yml`. The `node-version` input for the `./.github/setup-node` step has been eliminated and the action will fall back to the value in the `.nvmrc` file.
This removes the `node` matrix dimension (and its now-unused `event`-based exclude entries) from the `unit-js` job in `unit-test.yml`. The `unit-js-date` job's `strategy` is removed entirely, since `node` was its only matrix dimension. The `node-version` input for the `./.github/setup-node` step has been eliminated in both jobs and the action will fall back to the value in the `.nvmrc` file.
This workflow was missed by the earlier commits in this branch that
eliminated the `node` matrix dimension from `unit-test.yml` and
`create-block.yml` — it kept testing three Node versions (`20`, `22`,
`24`) via `actions/setup-node`'s `node-version: ${{ matrix.node }}`,
the same wasteful multi-version testing this branch will never need
since it's pinned to `.nvmrc`'s single version.
Removes the `node` matrix dimension and the `exclude` entry that
existed solely to restrict it on pull requests, and switches
`actions/setup-node` to `node-version-file: '.nvmrc'`. The job's
display-name template and remaining `os`-only exclude are adjusted to
match, preserving the existing behavior of showing a bare "All" for
the canonical `ubuntu-24.04` run and an OS suffix for the others.
…e calls. This file didn't exist in the tree when `f14d647a472` removed `check-latest: true` from every `actions/setup-node` call in the branch — it had been removed by the `remove-rn-workflows` layer at the time and was only restored afterward. Now that it's back, drop the same wasted-network-round-trip re-check from its two `actions/setup-node` steps for the same reason: the requested Node.js version is fixed by `.nvmrc` on this frozen branch and will never move.
desrosj
force-pushed
the
fix-actions-7.0/single-node-version-testing
branch
from
September 11, 2026 18:37
73842ac to
74cf291
Compare
Owner
Author
|
Migrated to real upstream: WordPress#82801. Closing this fork PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes
check-latest: truefrom everyactions/setup-nodecall, and eliminates thenodematrix dimension entirely (rather than just trimming the version list) fromcreate-block.ymlandunit-test.yml's Node-testing jobs, letting./.github/setup-nodefall back to the version in.nvmrc.Why?
check-latest: truere-checks the npm registry for a newer release matching the requested version range on every run. On a frozen branch the requested version is fixed by.nvmrcand will never move, so the check only adds a wasted network round trip.Testing against three Node.js versions (
20,22,24) makes sense ontrunk, where compatibility with upcoming Node releases matters. On a frozenwp/X.Ybranch there is exactly one Node version this code will ever actually run under in production, so testing the other two only multiplies CI time without adding coverage that reflects anything real.unit-test.yml'sunit-js-datejob hadnodeas its only matrix dimension, so itsstrategyblock is removed entirely rather than left with an empty matrix.create-block.yml's OS-restrictionexcludeentries (which are unrelated to Node version) are preserved.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.