Skip to content

Repair wp/7.0 branch Actions: Remove obsolete and trunk-only workflows - #141

Closed
desrosj wants to merge 7 commits into
wp/7.0from
fix-actions-7.0/remove-rn-workflows
Closed

desrosj wants to merge 7 commits into
wp/7.0from
fix-actions-7.0/remove-rn-workflows

Conversation

@desrosj

@desrosj desrosj commented Sep 1, 2026 •

Copy link
Copy Markdown
Owner

What?

Removes obsolete React Native mobile workflows and every workflow whose triggers make it trunk-only, from wp/7.0.

Workflow Purpose Reason removed
rnmobile-ios-runner.yml React Native iOS E2E tests Hardcodes if: false; has not run since before this branch existed
rnmobile-android-runner.yml React Native Android E2E tests Hardcodes if: false; has not run since before this branch existed
gradle-wrapper-validation.yml Validates the Gradle wrapper used by the Android tooling above Equally unused now that the tooling it validates never runs
storybook-pages.yml Deploys the canonical Storybook GitHub Pages site push: branches: [trunk] only
check-backport-changelog.yml Verifies a Core backport changelog entry pull_request: branches: [trunk] only
check-components-changelog.yml Verifies a @wordpress/components changelog entry pull_request: branches: [trunk] only
check-dataviews-changelog.yml Verifies a @wordpress/dataviews changelog entry pull_request: branches: [trunk] only
upload-release-to-plugin-repo.yml Publishes a Gutenberg plugin release to WordPress.org Triggers on GitHub release publication; releases are cut from trunk/release branches, never wp/X.Y
sync-assets-to-plugin-repo.yml Syncs assets/** to the WordPress.org plugin repo push: branches: [trunk] only
cherry-pick-wp-release.yml Auto cherry-picks labeled PRs to wp/X.Y branches Triggers only on pushes/labeled PRs against trunk; this branch is its destination, never its trigger source
sync-backport-changelog.yml Syncs Core backport changelog issues push: branches: [trunk], plus an issues: labeled trigger that isn't tied to any git ref — like the schedule case below, GitHub always runs it from the default branch's copy regardless of what's on this branch
stale-issue-gardening.yml Closes stale issues on a schedule GitHub only ever runs a scheduled workflow using the default branch's copy
pull-request-automation.yml Applies labels and milestones to pull requests before and after being merged. Every step explicitly checks out ref: trunk regardless of which branch or event actually triggered the workflow, so on wp/X.Y it only ever executes trunk's own copy of the automation. The trigger itself is real and does fire on this branch — but keeping a copy of the workflow file here is pointless, since it can never run anything but trunk's logic

Why?

Keeping dead or inapplicable workflow files around adds maintenance surface (stale action pins, lint noise) with no corresponding benefit.

The workflows removed cannot be meaningfully executed against a branch other than trunk.

  • For schedule events, the event only ever fires for the default branch.
  • Most others are responsible for automation that is only relevant to upcoming plugin releases, which occur from trunk (except minor releases, which come from the respective release/X.Y branch).

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

`rnmobile-ios-runner.yml` and `rnmobile-android-runner.yml` both
hardcode `if: false` on their only job and have not run on any push
or pull request since before this branch existed.
`gradle-wrapper-validation.yml` exists solely to validate the Gradle
wrapper used by that same disabled Android tooling, and is equally
unused as a result.
@desrosj
desrosj force-pushed the fix-actions-7.0/remove-rn-workflows branch from 2475307 to 9a456c8 Compare September 1, 2026 14:04
@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Flaky tests detected in 8a295c3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/desrosj/gutenberg/actions/runs/34549462844
📝 Reported tests:

should undo typing after non input change in /test/e2e/specs/editor/various/undo.spec.js, passed after 2 failed attempts.
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
    "blockIndex": 0,
-   "endOffset": 16,
-   "startOffset": 16,
+   "endOffset": 4,
+   "startOffset": 4,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/undo.spec.js:122:3
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
    "blockIndex": 0,
-   "endOffset": 16,
-   "startOffset": 16,
+   "endOffset": 4,
+   "startOffset": 4,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/undo.spec.js:122:3

@desrosj
desrosj force-pushed the fix-actions-7.0/remove-rn-workflows branch from 9a456c8 to d2a3fb8 Compare September 10, 2026 18:09
@desrosj
desrosj removed this pull request from stack #151 September 10, 2026 18:21
@desrosj
desrosj added this pull request to stack #179 September 10, 2026 18:22
@desrosj
desrosj marked this pull request as ready for review September 10, 2026 18:32
@desrosj
desrosj marked this pull request as draft September 10, 2026 18:41
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj marked this pull request as ready for review September 10, 2026 18:52
@desrosj
desrosj marked this pull request as draft September 10, 2026 20:09
@desrosj
desrosj force-pushed the fix-actions-7.0/remove-rn-workflows branch from d2a3fb8 to d88d164 Compare September 10, 2026 23:46
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 01:21
@desrosj
desrosj marked this pull request as draft September 11, 2026 03:21
`storybook-pages.yml` deploys the single canonical Storybook GitHub
Pages site and only triggers on pushes to `trunk`; there is one
Storybook site for the whole project, not one per branch, so this
branch's copy can never run.

`storybook-check.yml` is kept, not removed here — per updated
project policy, it is restored to this branch wherever a prior pass
removed it.
`check-components-changelog.yml`, `check-backport-changelog.yml`, and
`check-dataviews-changelog.yml` all trigger on
`pull_request: branches: [trunk]`, so none of them can run against a
pull request targeting this branch.
`upload-release-to-plugin-repo.yml` triggers on GitHub release
publication; Gutenberg plugin releases are cut from `trunk` and
release branches, never from `wp/X.Y` branches.

`sync-assets-to-plugin-repo.yml` triggers only on pushes to `trunk`
that touch `assets/**`.
`cherry-pick-wp-release.yml` only triggers on pushes to `trunk` or
labeled pull requests targeting `trunk`. `wp/X.Y` branches, including
this one, are the destination its `git push` step writes to, never
its trigger source.

`publish-npm-packages.yml` is kept on this branch per updated project
policy, even though it is only reachable via `workflow_dispatch`.
`sync-backport-changelog.yml` triggers only on pushes to `trunk`
(plus an issue-label event unrelated to any branch).

`stale-issue-gardening.yml` is schedule-triggered, and GitHub only
ever runs a scheduled workflow using the copy on the repository's
default branch, regardless of any copy present elsewhere.
Every step in `pull-request-automation.yml` explicitly checks out
`ref: trunk` regardless of which branch or event actually triggered the
workflow. On a `wp/X.Y` branch, that means the workflow only ever
executes trunk's own copy of the automation, never this branch's copy.
Keeping a copy of the workflow file here is pointless even though the
trigger itself is real and does fire on this branch.
@desrosj
desrosj force-pushed the fix-actions-7.0/remove-rn-workflows branch from 8a295c3 to 9ca40a9 Compare September 11, 2026 16:58
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 18:23
@desrosj

desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82797. Closing this fork PR.

@desrosj desrosj closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant