Skip to content

Repair wp/6.0 branch Actions: Test against a single Node.js version - #117

Closed
desrosj wants to merge 3 commits into
fix-actions-6.0/remove-mobile-unit-js-jobfrom
fix-actions-6.0/single-node-version-testing
Closed

desrosj wants to merge 3 commits into
fix-actions-6.0/remove-mobile-unit-js-jobfrom
fix-actions-6.0/single-node-version-testing

Conversation

@desrosj

@desrosj desrosj commented Aug 27, 2026

Copy link
Copy Markdown
Owner

What?

Removes the node matrix dimension from the two jobs on wp/6.0 that still test against multiple Node.js versions, and standardizes how every actions/setup-node call on this branch sources its Node.js version:

  • create-block.yml's checks job: removes node: [14] and its include: - node: 12 entry from the matrix, leaving only the os dimension.
  • unit-test.yml's unit-js job: removes node: ['12', '14'] and the now-empty strategy block along with it.
  • Every remaining actions/setup-node call across .github/workflows/ (whether it previously hardcoded node-version: 14 or read it from a single-value node matrix) now uses node-version-file: .nvmrc instead of an explicit node-version input.

Why?

This branch is frozen and will never need to verify compatibility across multiple Node.js versions again, so running the same tests twice against different Node.js versions only spends extra CI time without adding any coverage that matters. Standardizing every workflow on node-version-file: .nvmrc removes the redundant, easy-to-miss duplication of the Node.js version number across more than a dozen individual workflow steps, so the version used in CI always matches the one the rest of the toolchain (nvm, local development) already reads from .nvmrc.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from c4afa37 to ea9c37c Compare August 27, 2026 14:56
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch 2 times, most recently from 9a313f2 to 08895f5 Compare September 11, 2026 02:16
@desrosj
desrosj removed this pull request from stack #119 September 13, 2026 03:02
@desrosj
desrosj added this pull request to stack #329 September 13, 2026 03:02
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from 08895f5 to 4d628d5 Compare September 14, 2026 01:36
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from 4d628d5 to b5edd92 Compare September 14, 2026 01:52
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from b5edd92 to f0f3e4e Compare September 15, 2026 19:21
@desrosj
desrosj removed this pull request from stack #329 September 21, 2026 18:46
@desrosj
desrosj changed the base branch from fix-actions-6.0/update-actions-to-latest to wp/6.0 September 21, 2026 18:46
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from f0f3e4e to a13bfdd Compare September 21, 2026 18:52
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/update-actions-to-latest September 21, 2026 18:53
@desrosj
desrosj added this pull request to stack #404 September 21, 2026 18:54
@desrosj
desrosj removed this pull request from stack #404 September 21, 2026 19:38
@desrosj
desrosj changed the base branch from fix-actions-6.0/update-actions-to-latest to wp/6.0 September 21, 2026 19:39
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from a13bfdd to d5e7acb Compare September 21, 2026 19:41
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/update-actions-to-latest September 21, 2026 19:45
@desrosj
desrosj added this pull request to stack #418 September 21, 2026 19:45
@desrosj
desrosj removed this pull request from stack #418 September 21, 2026 21:52
@desrosj
desrosj changed the base branch from fix-actions-6.0/update-actions-to-latest to wp/6.0 September 21, 2026 21:52
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from d5e7acb to a67b65d Compare September 21, 2026 21:54
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/update-actions-to-latest September 21, 2026 21:56
@desrosj
desrosj added this pull request to stack #429 September 21, 2026 21:57
@desrosj
desrosj removed this pull request from stack #429 September 21, 2026 23:49
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/pin-wp-version-for-performance-tests September 23, 2026 01:50
@desrosj
desrosj added this pull request to stack #489 September 23, 2026 01:50
@desrosj
desrosj removed this pull request from stack #489 September 23, 2026 21:26
@desrosj
desrosj changed the base branch from fix-actions-6.0/pin-wp-version-for-performance-tests to wp/6.0 September 23, 2026 21:27
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/pin-wp-version-for-performance-tests September 23, 2026 21:29
@desrosj
desrosj added this pull request to stack #502 September 23, 2026 21:30
@desrosj
desrosj removed this pull request from stack #502 September 24, 2026 18:18
@desrosj
desrosj added this pull request to stack #522 September 24, 2026 18:19
@desrosj
desrosj removed this pull request from stack #522 September 28, 2026 14:36
@desrosj
desrosj added this pull request to stack #543 September 28, 2026 14:38
@desrosj
desrosj removed this pull request from stack #543 September 28, 2026 19:11
@desrosj
desrosj changed the base branch from fix-actions-6.0/pin-wp-version-for-performance-tests to wp/6.0 September 28, 2026 19:11
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from 2c59c46 to ff5536e Compare September 28, 2026 19:12
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/pin-wp-version-for-performance-tests September 28, 2026 19:12
@desrosj
desrosj added this pull request to stack #569 September 28, 2026 19:12
@desrosj
desrosj removed this pull request from stack #569 October 5, 2026 18:42
@desrosj
desrosj added this pull request to stack #605 October 5, 2026 18:43
@desrosj
desrosj removed this pull request from stack #605 October 5, 2026 20:55
@desrosj
desrosj added this pull request to stack #618 October 5, 2026 20:56
@desrosj
desrosj removed this pull request from stack #618 October 6, 2026 17:56
@desrosj
desrosj added this pull request to stack #634 October 6, 2026 17:56
Removes the `node` matrix dimension (and the `node: 12` `include`
entry it drove) from the `checks` job, leaving only the `os` matrix
dimension. This branch is frozen and will never need to verify
compatibility across multiple Node.js versions again, so testing more
than one only spends extra CI time without adding coverage that
matters. The job's `actions/setup-node` step now reads `node-version-file: .nvmrc`
instead of a matrix-driven value, so it always uses the same version
declared in `.nvmrc`.
Removes the `node` matrix dimension, and the `strategy` block that
only existed to hold it, from the `unit-js` job. This branch is frozen
and will never need to verify JavaScript unit test compatibility across
multiple Node.js versions again, so testing more than one only spends
extra CI time without adding coverage that matters. The job's
`actions/setup-node` step now reads `node-version-file: .nvmrc`
instead of a matrix-driven value, so it always uses the same version
declared in `.nvmrc`.
Replaces every remaining hardcoded or matrix-driven `node-version`
input to `actions/setup-node` across `.github/workflows/` with
`node-version-file: .nvmrc`. This branch is frozen at a single Node.js
version going forward, so hardcoding that version separately in each
workflow step is redundant and creates a second place that would need
updating if the version ever changed. Reading it from `.nvmrc` instead
keeps every workflow's Node.js version in sync with the single source
of truth the rest of the toolchain already uses.

# Conflicts:
#	.github/workflows/unit-test.yml

# Conflicts:
#	.github/workflows/build-plugin-zip.yml
@desrosj
desrosj removed this pull request from stack #634 October 7, 2026 18:02
@desrosj
desrosj changed the base branch from fix-actions-6.0/pin-wp-version-for-performance-tests to wp/6.0 October 7, 2026 18:02
@desrosj
desrosj force-pushed the fix-actions-6.0/single-node-version-testing branch from ff5536e to 9ea2c32 Compare October 7, 2026 18:04
@desrosj
desrosj changed the base branch from wp/6.0 to fix-actions-6.0/remove-mobile-unit-js-job October 7, 2026 18:05
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant