Skip to content

Repair wp/6.1 branch Actions: Test against a single Node.js version - #102

Closed
desrosj wants to merge 2 commits into
fix-actions-6.1/remove-mobile-unit-js-jobfrom
fix-actions-6.1/single-node-version-testing
Closed

desrosj wants to merge 2 commits into
fix-actions-6.1/remove-mobile-unit-js-jobfrom
fix-actions-6.1/single-node-version-testing

Conversation

@desrosj

@desrosj desrosj commented Aug 27, 2026

Copy link
Copy Markdown
Owner

What?

Removes the node matrix dimension from unit-test.yml's unit-js job and from create-block.yml, both of which already only ever ran a single Node.js version (14) through that dimension. Both jobs now use node-version-file: '.nvmrc' when calling actions/setup-node, instead of passing an explicit node-version sourced from the matrix. create-block.yml's os matrix dimension (macos-latest, ubuntu-latest, windows-latest) is left untouched, since it still produces real, distinct coverage.

This branch has no check-latest: true usage anywhere in actions/setup-node calls, so there was nothing to remove for that.

Why?

This branch is frozen and will never test against more than one Node.js version, so a matrix dimension that only ever produces a single combination adds indirection without adding any coverage. Pinning to .nvmrc keeps the Node.js version driven by a single source of truth instead of being duplicated in the workflow files.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from 5209f49 to 853885a Compare August 27, 2026 14:58
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch 2 times, most recently from 28bed83 to c8695f1 Compare September 11, 2026 00:25
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch 2 times, most recently from b53043d to 80f643c Compare September 11, 2026 02:16
@desrosj
desrosj removed this pull request from stack #107 September 13, 2026 01:31
@desrosj
desrosj added this pull request to stack #323 September 13, 2026 01:31
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from 80f643c to b9c7706 Compare September 14, 2026 01:33
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from b9c7706 to c6c857a Compare September 14, 2026 01:40
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from c6c857a to cbcca1b Compare September 15, 2026 21:22
@desrosj
desrosj removed this pull request from stack #323 September 21, 2026 21:42
@desrosj
desrosj changed the base branch from fix-actions-6.1/update-actions-to-latest to wp/6.1 September 21, 2026 21:42
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/update-actions-to-latest September 21, 2026 21:48
@desrosj
desrosj added this pull request to stack #425 September 21, 2026 21:48
@desrosj
desrosj removed this pull request from stack #425 September 21, 2026 23:47
@desrosj
desrosj changed the base branch from fix-actions-6.1/update-actions-to-latest to wp/6.1 September 21, 2026 23:48
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/update-actions-to-latest September 21, 2026 23:57
@desrosj
desrosj added this pull request to stack #443 September 21, 2026 23:57
@desrosj
desrosj removed this pull request from stack #443 September 22, 2026 00:49
@desrosj
desrosj added this pull request to stack #451 September 22, 2026 01:02
@desrosj
desrosj removed this pull request from stack #451 September 22, 2026 15:53
@desrosj
desrosj changed the base branch from fix-actions-6.1/update-actions-to-latest to wp/6.1 September 22, 2026 15:53
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from cbcca1b to 1b9c381 Compare September 22, 2026 15:56
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/pin-wp-version-performance-testing September 23, 2026 21:36
@desrosj
desrosj added this pull request to stack #506 September 23, 2026 21:36
@desrosj
desrosj removed this pull request from stack #506 September 24, 2026 18:16
@desrosj
desrosj added this pull request to stack #520 September 24, 2026 18:17
@desrosj
desrosj removed this pull request from stack #520 September 28, 2026 14:34
@desrosj
desrosj added this pull request to stack #541 September 28, 2026 14:36
@desrosj
desrosj removed this pull request from stack #541 September 28, 2026 19:09
@desrosj
desrosj changed the base branch from fix-actions-6.1/pin-wp-version-performance-testing to wp/6.1 September 28, 2026 19:09
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from f8f9581 to 965405c Compare September 28, 2026 19:09
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/pin-wp-version-performance-testing September 28, 2026 19:09
@desrosj
desrosj added this pull request to stack #568 September 28, 2026 19:10
@desrosj
desrosj removed this pull request from stack #568 September 29, 2026 00:26
@desrosj
desrosj changed the base branch from fix-actions-6.1/pin-wp-version-performance-testing to wp/6.1 September 29, 2026 00:27
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/pin-wp-version-performance-testing September 29, 2026 00:28
@desrosj
desrosj added this pull request to stack #574 September 29, 2026 00:28
@desrosj
desrosj removed this pull request from stack #574 October 5, 2026 20:48
@desrosj
desrosj added this pull request to stack #611 October 5, 2026 20:48
@desrosj
desrosj removed this pull request from stack #611 October 6, 2026 14:20
@desrosj
desrosj added this pull request to stack #621 October 6, 2026 14:21
…t job.

Removes the single-item `node: ['14']` matrix dimension from the
`unit-js` job and stops passing an explicit `node-version` to
`actions/setup-node`, switching to `node-version-file: '.nvmrc'`
instead, matching how the other jobs in this workflow already resolve
their Node.js version. This branch is frozen and will never test
against more than one Node.js version, so a matrix that only ever
produces a single combination adds indirection without adding any
coverage, and pinning to `.nvmrc` keeps the version driven by a single
source of truth instead of being duplicated in the workflow file.
Removes the single-item `node: [14]` matrix dimension and stops
passing an explicit `node-version` to `actions/setup-node`, switching
to `node-version-file: '.nvmrc'` instead. The `os` matrix dimension is
left untouched since it still produces real, distinct coverage across
`macos-latest`, `ubuntu-latest`, and `windows-latest`. This branch is
frozen and will never test against more than one Node.js version, so
a matrix dimension that only ever produces a single value adds
indirection without adding any coverage, and pinning to `.nvmrc` keeps
the version driven by a single source of truth instead of being
duplicated in the workflow file.
@desrosj
desrosj removed this pull request from stack #621 October 7, 2026 18:02
@desrosj
desrosj changed the base branch from fix-actions-6.1/pin-wp-version-performance-testing to wp/6.1 October 7, 2026 18:02
@desrosj
desrosj force-pushed the fix-actions-6.1/single-node-version-testing branch from 965405c to cf370bb Compare October 7, 2026 18:04
@desrosj
desrosj changed the base branch from wp/6.1 to fix-actions-6.1/remove-mobile-unit-js-job October 7, 2026 18:05
@desrosj
desrosj added this pull request to stack #667 October 7, 2026 18:05
@desrosj
desrosj marked this pull request as ready for review October 8, 2026 03:26
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84245.

@desrosj desrosj closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant