Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/common.py
descope/management/tenant.py
|
|
coverage % went down @guyp-descope please advise |
@ruvenzx you can see the lines that are not covered by tests, just add missing tests: 
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds tenant session settings management functionality to the Descope SDK, enabling users to configure and retrieve session-related settings for tenants including token expiration times, inactivity settings, and authentication types.
- Adds
update_settings()andload_settings()methods to the Tenant class for managing tenant session configurations - Introduces new enums
SessionExiprationUnitandTenantAuthTypeto support session settings parameters - Includes comprehensive test coverage for both new methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| descope/management/tenant.py | Implements update_settings() and load_settings() methods for tenant session settings management |
| descope/management/common.py | Adds SessionExiprationUnit and TenantAuthType enums and tenant_settings_path constant |
| tests/management/test_tenant.py | Adds test cases for update_settings() and load_settings() methods |
| README.md | Documents the new tenant settings management functions with usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 participants
Related Issues
Fixes https://github.com/descope/etc/issues/12385