Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to create outbound applications using DCR (Dynamic Client Registration) presets, providing an alternative creation method to the existing manual application creation.
- Adds a new method
create_application_by_dcr_presetto the outbound application management - Introduces a new API endpoint path for DCR preset-based application creation
- Includes comprehensive test coverage for both success and failure scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| descope/management/outbound_application.py | Implements the new create_application_by_dcr_preset method with proper documentation |
| descope/management/common.py | Adds the API endpoint path for DCR preset application creation |
| tests/management/test_outbound_application.py | Adds unit tests for both success and failure cases of the new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/outbound_application.py
descope/management/common.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Description
Add the ability to create outbound application according to existing dcr preset
Must