Conversation
allow creating tenants with parent ids related to descope/etc#9374 + tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for hierarchical tenants by allowing the creation of sub-tenants with parent relationships. It also enhances user search functionality to optionally include users from sub-tenants.
- Added ParentID field to TenantRequest for creating sub-tenants
- Added IncludeSubTenants flag to UserSearchOptions for hierarchical user searches
- Updated tenant creation logic to handle parent-child relationships
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| descope/types.go | Added ParentID field to TenantRequest and IncludeSubTenants flag to UserSearchOptions |
| descope/internal/mgmt/user.go | Updated user search request to include the IncludeSubTenants parameter |
| descope/internal/mgmt/tenant.go | Modified tenant creation/update logic to handle parent ID when creating sub-tenants |
| descope/internal/mgmt/tenant_test.go | Updated test to verify parent ID is properly included in tenant creation requests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dorsha
reviewed
Aug 27, 2025
dorsha
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow creating tenants with parent ids
related to https://github.com/descope/etc/issues/9374