Repository navigation
Divide 付, 代, 候, 芦 and 农 under locales.ZH (#952) - #975
Merged
Merged
Conversation
Add four mainland surnames that neither ranking's top 300 reaches by hand at the tail of zh.py's census block, annotated as 萧 is, with 農, the traditional form the Taiwan ranking attests. They are the mainland's 65th, 106th, 187th and 198th by people (NCIIC 2008), the unlisted ones in its top 200 save 芦, which opens 102 Japanese names and is left out. Under parser_for(locales.ZH), wainshine/Chinese-Names-Corpus's mainland list leaves 29,331 of 1,144,226 names whole, down from 34,472; its Japanese list gains 14 wrong divisions, all 代 (代田稔). The default parse does not move. Closes #952 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
芦 is the mainland's 197th surname by people, the last unlisted one in its top 200; 蘆 is its traditional form, Taiwan's 642nd. It opens 102 of the 172,413 names in wainshine's Japanese list (芦田, 芦川, 芦名), and 蘆 21 more, now divided after it: the cost decisions/W1 records beside 安's and 代's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eadline Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wikidata ranks 农 585th through its 農 item; only 芦 has no item. Date the Taiwan and Wikidata figures in zh.py's comment, and call the rows zh_surnames.py reads by hand "the hand-kept rows", since they now hold seven entries that are not census rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #952.
parser_for(locales.ZH).parse("付晓明")now gives family付, given晓明; through 2.8.0 it gave family付晓明.What changed
Five mainland surnames are added by hand at the tail of zh.py's census block, each annotated with its evidence as
萧is:付,代,候,芦and农. With them come蘆and農, the traditional forms the Taiwan ranking attests.蘆) and 317th (農).tools/zh_surnames.py --writereproduces it byte for byte.decisions/W1 (unspaced CJK division) gets the following:
Measured
All measured with
parser_for(locales.ZH), comparing 4ebb51d with this branch, and asserting__file__on each side.tw-donors(308,667 names), moved蘆.The list files hold one more name each than #952 counted (1,144,226 and 172,413 non-empty lines after the header). The counts above use those totals.
Tests
zh, plus the traditional農建華and蘆建國.代田稔→ family代, and芦川誠→ family芦.corpus_cjk.jsonlandsnapshot.jsonlregenerated for the new rows.uv run pytest,-n0 -m serial, mypy and ruff. The suite was also run with namedivider installed and without it.Left open
The Open line for a mainland-weighted third source in
tools/zh_surnames.pyhas no issue yet, and #952 closes with this PR. A draft for one is waiting for a decision on filing it.🤖 Generated with Claude Code