Repository navigation
State what family and the patronymic view hold where a convention has no family name (#1253, #1203) - #1367
Open
derek73 wants to merge 3 commits into
Open
State what family and the patronymic view hold where a convention has no family name (#1253, #1203)#1367derek73 wants to merge 3 commits into
derek73 wants to merge 3 commits into
Conversation
… no family name (#1253, #1203) rules/O's Background states #1253's first statement, that family is the name a convention files a person under, and rules/R9 its second, that the patronymic view may overlap the family. rules/O4 records the Ethiopian name as an accepted consequence. decisions gains a key for the decision, with #1203's measurements re-taken where the cache allows. docs/usage.rst says what family holds for such a name, and docs/matching.rst gives the matcher for an Ethiopian list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From review: the Background and the decisions entry said the Mongolian and Kyrgyz readings are what position gives, which holds only once #1237's pack and #1187's reading land, and pointed at their unmerged entries; Burma's `Aung San Suu Kyi` loses `San` to the particle fold. The matching recipe uses invented names, says the fold compares family words regardless of order (a swapped father and grandfather match), gives the measured reason to keep the default parser for the fields, and its heading says "inherited". R9 keeps the decision's "overlap"; the Open line restates no issue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ition From the round-2 review: San inside a name joins the family forward (rules/P2), not P1's fold; the Background says the Mongolian and Kyrgyz readings need the caller's declaration, without claiming a setting the tree lacks; the matcher, not the fold, compares a several-word family regardless of order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1203. Refs #1253.
This records #1253's decision in the rules, and settles #1203 (Ethiopian names) as the decision says: no default reading changes. It touches only docs; no library code changes.
What it adds
rules/O-name-order.md):familyis the name a convention files a person under, not necessarily an inherited one. For an Ethiopian name, that is what position gives. The Mongolian and Kyrgyz readings need the order and the marker rule those conventions turn on, which land in Add locales.MN, a Mongolian pack reading a Cyrillic name's father's name as the family (#1237) #1365 and Read a Turkic marker ending three name words with the father's name as the family (#1187) #1366. The wording holds whichever of the three PRs merges first.Abiy Ahmed Ali→ familyAliAbiy Ahmed→ familyAhmeddecisions/family-without-an-inherited-name, holding:-ұлы/-қызыwritten as one word? (Тилектес Серикбайулы АДАМБЕКОВgives patronymic'') #1188, Should a family name after aبنchain stay out of the patronymic? (خالد بن سعد القحطانيgives patronymic 'بن سعد القحطاني') #1155, Should a Burmese choice readUandDawas titles, and stopSanjoining the family? (Daw Aung San Suu Kyigives given 'Daw', family 'San Suu Kyi') #1231, and ShouldS/O,D/OandW/Omark the parent's or husband's name, asbindoes? (Ravi Kumar S/O Mohan Lalgives middle 'Kumar S/O Mohan') #1165 as a decision of its own);Abiy Ahmed Aligives middleAhmed;Abiy Ahmedgives familyAhmed) #1203's measurements, re-taken where the cache allows, as dated snapshots.docs/usage.rst: a short passage beside thepatronymicview on whatfamilyholds for a name with no inherited family name.docs/matching.rst: a "Names with no inherited family name" section. Its recipe is a matcher built fromParser(policy=Policy(middle_as_family=True))for a list known to follow the convention, with the default parser kept for reading the fields. The examples use invented names.Measured (2026-11-12, master 2b39f23)
et_hopr, from theopensanctions-parliamentsfetch of 2026-11-12, 23 datasets):middle) and grandfather (family).Abiy Ahmed Aligives middleAhmed;Abiy Ahmedgives familyAhmed) #1203 counted 2,291 on the 2026-11-08 fetch; the dataset itself has changed since.config_diff.py score default 'default@middle_as_family=1' --group ET --group ER):middle_as_family(18,794 records).Abiy Ahmed Ali/Abiy Ali Ahmed), where the default matcher keeps them apart. Under either matcher, a two-word name whose second word is the other name's grandfather is consistent too. The recipe says both.Not re-taken: #1203's ORCID box splits and its Wikidata P734 count. The decisions entry quotes them as the issue's 2026-11-08 figures.
Found while writing it
Saninside a Burmese name joins the family forward (rules/P2):Aung San Suu Kyi→ givenAung, familySan Suu Kyi. The decision says the last word of a Burmese name is the family by position, so this is a case for Should a Burmese choice readUandDawas titles, and stopSanjoining the family? (Daw Aung San Suu Kyigives given 'Daw', family 'San Suu Kyi') #1231's pack. It is recorded in the decisions entry; no issue was filed.Open:line names any of Where does a father's name go when the name has no family name? (Abiy Ahmed Ali,Ухнаагийн Хүрэлсүх,Бекмырза Чолпонбай уулу) #1253's questions.Checks
uv run pytest: 46,001 passed. Python 3.15 in its own environment: 45,969 passed.uv run pytest -n0 -m serial: 35 passed.mypyandruff: clean.sphinx-build -b doctest docs(835 tests, 0 failures) and-W -b html: clean.python -m doctest README.rst: clean.Reviews
San). The Open line contradicted its Log on #1165. R9 narrowed "overlap".foldedclashed with the outcome of the same name.Saninside a Burmese name joins the family forward (rules/P2), not by P1's fold. The Background implied a Kyrgyz marker setting a caller can turn on today, which no shipped setting gives. The order-blind comparison is the matcher's, not the fold's. Everything else re-verified: the 21.5 points, the matching table, both builds.🤖 Generated with Claude Code