Repository navigation
Use Taylor Morgan, a name with no evidence, in the group suggester's headline example - #1362
Merged
Merged
Conversation
…evidence The headline list's first name was Smith Mary, which votes for itself (Mary is in the given-name table), so the example read as if the parser recognized it. Taylor Morgan casts no vote and is read family first only because the rest of the list is. Name what voted, what gave no evidence and what disagreed after each printout, and add to suggest.rst a list decided by given names at the end and one that carries no evidence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing name apart A caller's list from one source is written one way, so the headline list is now family first throughout: Mary Smith gives way to Garcia Emily, which votes by its given name at the end. The disagreeing name moves to its own step in suggest.rst (Emily Clark), with getting-started pointing there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the first commit: the page's own no-evidence examples are common given names, so the evidence list now names the table's bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group suggester's headline example opened with
Smith Mary, which votes for itself (Maryis in the given-name table), so it read as if the parser recognized the name. The example now opens withTaylor Morgan: both words are ordinary given names and ordinary surnames, neither is in the suggester's tables, and it is read family first only because the rest of the list is. The headline list is also written in one order throughout, as a list from one source is, soMary Smith(given first) is replaced byGarcia Emily, which votes by the given name at the end.Changed examples (outputs taken from the tree)
Headline list in
README.rst,docs/getting-started.rst,docs/suggest.rstand the 3.1Parser.suggest()release-log bullet:["Smith Mary", "Kim Minjun", "Wang Xiaoming", "Nguyen Anh", "Mary Smith"], which printed4 for, 1 against, 0 no evidencewithdisagreeing (1): Mary Smith["Taylor Morgan", "Kim Minjun", "Wang Xiaoming", "Nguyen Anh", "Garcia Emily"], which printsname_order FAMILY_FIRST 4 for, 0 against, 1 no evidence(surname 3, given-name FAMILY_FIRST 1) with no disagreeing line.parse("Taylor Morgan").givenis'Taylor', and the suggested parser reads it as'Morgan'.The prose after each printout names the roles:
Kim,WangandNguyenvote by the romanized surname in front, andGarcia Emilyby the common given name at the end.Taylor Morgangives no evidence, and nothing in the name can confirm the reading it gets. The opening claim now says one name often cannot show its order.Matching example in
getting-started.rst: the registry is nowTaylor Morgan+ the three surnames.check(registry.parse("Taylor Morgan"), parse("M. Taylor"))is consistent, and with the default parser it is not.New in
docs/suggest.rst, each a doctest:suggest-disagreeing, linked from getting-started): the headline list plusEmily Clarkprints4 for, 1 against, 1 no evidenceanddisagreeing (1): Emily Clark, and the suggested parser reads given'Clark'.["Parker Emma", "Reed Sophie", "Ellis Jordan"]givesPolicyPatch(name_order=FAMILY_FIRST), decided by the given names at the end.Ellis Jordancarries none and is read given'Jordan'. This uses given names rather than capitals because a capitalsPolicyswitch is in flight in another branch.["Taylor Morgan", "Jordan Casey", "Avery Quinn"]givesPolicyPatch().The evidence list in
suggest.rstand the release-log bullet now say a given name votes only if it is rarely a surname (Emily, notTaylor). Without that, the new no-evidence examples, which are built from common given names, would contradict them.Checks
sphinx-build -b doctest docs: 828 tests, 0 failures (822 on master)sphinx-build -W -b html docs: cleanpython -m doctest README.rstandreadme_renderer: cleanuv run pytest: 45962 passed, 38 skipped, 3 xfaileduv run mypyanduv run ruff check: cleanReview
A reviewer subagent worked in its own detached worktree and ran twice: on the first head, then on the head that rewrote the list in one order. Each time it ran every changed example and checked every sentence about who voted against the printed
NameEvidence.Kim Minjun. Both are fixed.Garciais not one of the surnamessuggestreads. All are fixed.Left out of scope: the
TypeErrormessage innameparser/_suggest.pystill offersparser.suggest(["Smith Mary", "Kim Minjun"])as its example. That is library code.🤖 Generated with Claude Code