Repository navigation
Replace the group suggester's example name with Smith Mary - #1354
Merged
Merged
Conversation
The suggester's docs, release bullet, error message and tests used an example name that may be a real person's; they now use Smith Mary / Mary Smith. Mary is in the given-name table and Smith in no surname table, so every name votes as the one it replaces. Where the swap would have made two names in one group equal, the other name became Ruth Hollis (and Mary Hollis). No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rename with no behavior change. The group suggester's example name may be a real person's name, so it is replaced with
Smith Mary/Mary Smith(Smith, Maryin comma form) indocs/suggest.rst, theParser.suggest()release bullet, the bare-string error message innameparser/_suggest.py, andtests/v2/test_suggest.py,test_reprs.pyandtest_types.py. The docs-rewrite PR #1353 doesn't touch these files, and none of its files holds the name.Why this pair:
maryis inCOMMON_GIVEN_NAMESandsmithis in neitherCOMMON_GIVEN_NAMESnorROMANIZED_SURNAMES. That matches the names they replace, where the given name votes and the surname does not, so every name votes as the one it replaces.Collision renames: four groups already held a
Mary Smith, which the swap would have duplicated. There, the existingMary SmithbecameRuth Hollis(ruthis a listed given name,hollisis in no table). In one of those groups, the other name that held the old surname becameMary Hollis. Intest_reprs.py, the words checked for absence from the repr are now("Mary", "Kim", "Smith"), so the list holds no duplicate. No expected value changed except the name text.How "no behavior change" was shown:
Parser.suggestand logged every call the three test modules make: the input names, the patch, each name's votes, each evidence's setting, decision, votes and note, and the disagreeing names. That came to 292 calls, run on master and on this branch.docs/suggest.rstdoctest and the release bullet's example.suggest([...]).parser.parse("Smith Mary")gives givenMary, familySmith, andParser().parse("Smith Mary")gives givenSmith, familyMary, so the bullet's sentence still holds as written.Checks:
uv run pytest(45,962 passed),uv run pytest -n0 -m serial(35 passed),uv run mypy,uv run ruff check,sphinx-build -b doctest docs(0 failures),sphinx-build -W -b html docs,python -m doctest README.rst.git grep -ifinds no trace of the old name anywhere in the tree.🤖 Generated with Claude Code