Repository navigation
List credentials written in two chunks joined at a full stop (#998) - #1297
Merged
Merged
Conversation
43 credentials such as B.Pharm, C.Psych, M.Tech, M.Kes, S.Kom and M.Pd are listed, so the vocabulary reads them whole before rules/S3's shape: Ahmed Ali B.Pharm reads suffix 'B.Pharm' with no suffix-or-name report, Ayu Pangestu, S.Pd, M.Pd reads suffix 'S.Pd, M.Pd' where the title chunk pd made it a title, and Anna Gelavis, BPharm no longer reverses. msi is marked ambiguous (Msi, a Xhosa surname); twelve folds that are names or another word are refused (peng, ceng, barch, bchir, mendo, bed, ssi, sked, shut, merg, mak, mor). decisions/period-joined-words records the division's cost against the batch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test review found msi, marked ambiguous, still took the Xhosa surname from a name in one case (ANDISWA ZANELE MSI), the shape cota was refused for, so it is refused too. New case rows pin the spelling without stops (Anna Gelavis, BPharm; JOHN SMITH MPHARM), the no-comma and one-word-head shapes, and the refusals of ssi, msi and bed (Thapa, Bed, a real control where Bed Bahadur Thapa was not); a render test pins the masks. msci loses its mask (written MSCI far more often), the M.Hassan row is fix(#516), and the release bullet names the release ranges. The division figure now leaves out every token the suffix sets list (L.Ac) and counts M.Si, which msi's refusal leaves unlisted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The second review measured that refusing msi cost comma names (Jane Doe, MSi reversed; Saprudin S.Sos., M.Si. read given 'M.Si.') while the capitals shape marking costs is written in no local corpus, so msi is marked ambiguous with no mask, and three rows pin it, the capitals one as the accepted cost. The ded Standing line is corrected to the position the suffix claim reaches (Thapa, Ded) and a Standing line records the batch; the period-joined-words Open line moves to #1255, since this PR closes #998; the division figure leaves M.Si out as listed (44 credentials at any chunk length) and counts the refused tokens by subset; bed's gain is 10 records; the corpora are measured again on the final tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The third review measured the suffix claim reaching a trailing given name under a family-first order too (Luli Ded), and edd as ded; the #540 entry gets a head note naming the corrected premise. bed's gain is 6 readings of the 10 records, 3 in a field. A pointer to the renamed Open line is restated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #998
Lists the credentials written in two chunks joined at a full stop that #998 measured and the six local corpora show, so the vocabulary reads each word whole before rules/S3's shape does. This is step 2 of decisions/period-joined-words (#1291): the division of a word at its full stop has to come after this batch.
What changes
tools/vocab/query.py,tools/name_usage.py, counts in thenote), each with acasedmask exceptmsciandmsi:en.toml:bpharm,cpsych,mpharm,msci,mtech,dtech,dsci,mmath,moptom, and others.id.toml:mkes,mkep,mkom,skom,mpd,spd,mhum,mkn,msi, and others.menfinpt.toml.msimarked ambiguous by a family reading, Msi being a Xhosa surname. Refusing it reversedJane Doe, MSi. Marking it costsANDISWA ZANELE MSIits surname, which no local corpus writes; a row pins that as the accepted cost.excludedentries, because the spelling without stops is a name or another word:peng,ceng: Chinese surnames.barch,bchir,mendo,sked,shut,merg,mak,mor: borne as names.bed: the Nepali given name.ssi: the romanized Korean honorific 씨, as inPark Ji-hoon ssi.btechleft unlisted on purpose.B.Techis the example of an unlisted dotted credential in eleven files, including comments in_pipeline/_vocab.pyand_render.py. Moving those examples is a follow-up of its own.Ahmed Ali B.Pharmsuffix-or-nameAyu Pangestu, S.Pd, M.Pdpdis a title)Anna Gelavis, BPharmAli C.PsychAhmed Ali M.HassanMeasured (2026-11-09)
tools/differential/measure.py --baseagainst master b89c548, then the corpora that moved again on the final tree.Bernd Lange SPD: family 'Lange', suffix 'SPD'); psc-individuals 1, its report only (Mr Afikile Manduleli Msi).The division's cost, which decisions/period-joined-words' Open line on unlisted credentials asks for, is in that file's new Log bullet. Over the six corpora #998 counted:
P.Eng4,B.Chir2, …). With second chunks of any length, the cost is 44 (M.Ed8,B.Ch5, …), 42 of them after a comma.For a decision
bedis refused for the given part after a family comma (Thapa, Bedreads suffix 'Bed' with the word listed), though no local corpus writes that shape, against a gain of 6 readings (3 in a field). decisions/suffix-acronym-collisions' Standing line fordedsays a given name is not a position the suffix claim acts on, andThapa, Dedreads suffix 'Ded' today. That Standing line is corrected to say the claim reaches a given name after a family comma and under a family-first order (Luli Ded), foreddtoo, and both stay unmarked; whether to reopen them is yours.Docs
nameparser/vocab/AGENTS.mdnow says to vet a dotted credential's spelling without stops.Reviewed by design-docs-reviewer (twice), pr-test-analyzer and code-reviewer; their findings are fixed in the second and third commits. The period-joined-words Open line moves from #998 to #1255, since this PR closes #998.
🤖 Generated with Claude Code