Repository navigation
Read a transliterated Cyrillic initial opening a name as a given name, not a title (rules/H2, #1136) - #1294
Merged
Conversation
…tle (rules/H2, #1136) rules/H2's leading-abbreviation shape read any unlisted two-letter word ending in a period as a title, so Yu. A. Chibrikova read title 'Yu.'. The Latin spellings of one Cyrillic letter that are no title in any corpus read (Yu Ya Ye Yo Zh Kh Shch Dzh) now decline the shape, in both spellings of the test. Ts, Ch and Sh, each also a title written short, keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#1136 Open line Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… scope The design-docs review found that period-joined-words gave the glued Ts.Sandag-Ochir its spaced twin's reading, which the file's own division rule refuses, and that the reason given for leaving Th out (Th. D.) does not hold at H2's slots. The Cyrillic row moves to the single-letter bullet, and the boundary rows are titles that are right as titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…verride The second review found that Dutch Th. for Theodorus is a given name written short, not a digraph of another alphabet; that Ts.Sandag-Ochir not dividing holds only while ts is unlisted (vi lists it); and that a caller restores the title reading by listing the word as a title. Adds rules/H2's comma-count row for a digraph, Yu. Smith, Ed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment review: name the transliteration-digraph Except where H2 now has three, say what the test's boundary loop holds, and narrow the release log and migrate text to the eight digraphs (LC's Iu. is unchanged). Test review: pin is_leading_title's value for the digraphs directly, and the title-phrase head run (Vice Yu. Petrov) as a rule example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1136.
rules/H2 (the leading-abbreviation title) read any unlisted word of two letters ending in a period as a title when it opened a name, so a transliterated Cyrillic initial became a title.
Yu. A. Chibrikovaread title 'Yu.', given 'A.', andYu. Baryshnikovlost its given name. The same happened after a family comma (Chibrikova, Yu. A.) and behind a title (Dr. Yu. Petrov→ title 'Dr. Yu.'), from 1.4.0 through 3.0.1. The Cyrillic original,Ю. А. Чибрикова, already read given 'Ю.'.What changes. The shape now declines a closed set of transliteration digraphs, the Latin spellings of one Cyrillic letter, in any case:
Yu,Ya,Ye,Yo,Zh,Kh,ShchandDzh(_vocab._DIGRAPH_INITIALS). Both spellings of H2's test read the set:_vocab.is_title_shapedand the inline copy in_pieces.is_leading_title. The check is C-level and adds no frame.Which digraphs, and why this set. The set was chosen from three options (vocabulary word by word, a shape exception, the RU pack only) and narrowed to the digraphs that no corpus reads as a title. I counted every unlisted period word opening a name, or the part after a family comma, that master read as a title. The corpora were orcid-researchers, nepal-candidates, ctgov-officials, psc-individuals, opensanctions-parliaments, patentsview-inventors and jrc-names.
Yu/Ya/Ye/Yo/ZhandKhwere never a title there.Chreads about 8 times as an initial, against 4 uses as Chaudhry.Shreads 2 times as an initial, against 4 uses as Sheikh or Shri.Ts.openers are the Malaysian professional title.Those three keep the title reading, and what a Mongolian
Ts.reads as is #1235's question.Th(Greek Θ, or Dutch Theodorus written short) is out by scope, not by evidence. The full table is in decisions/H2's 2026-11-09 #1136 entry.What it reads as. The digraph is a name word, not the initial T5 tags. Over a grid of 24 shapes (the comma shapes, titles, a particle, a nickname, a suffix, a lone word) under all three orders, every digraph in the set reads field for field as
J.does. The one difference is a lone digraph, which reportsgiven-or-familywhereJ.reports nothing. A caller who wantsYu.as a title still lists it as one (Lexicon.default().add("yu", kind="title")), which outranks the shape. The Library of Congress spellings (Iu., the tiedI͡U.) are outside the set. The ISO 9 one-letter spellings were initials already, composed or decomposed.Measured against master b89c548:
snapshot.py --local --base <master>matches the base for nepal-candidates, ctgov-officials and patentsview-inventors.local_agreement.py --base <master>matches the base for psc-individuals, and changes 2 orcid-researchers records, both toward the boxes their filers typed.Docs.
Yu. A. ChibrikovareadYu.as a given-name initial? Two-letter initials at the start of a name read as titles #1136 Open line becomes a Standing answer. The digraph set is a chunk the division reads on its own.Ts.Sandag-Ochirdoes not divide under the default vocabulary, and what it should read is left to Should a title glued to the given name by its period split? (Dr.John Smithgives title 'Dr.John', no given name) #1230 and Should an initial glued to a name split at its period? (Ц.Сандаг-Очирgives given 'Ц.Сандаг-Очир', no family) #1235.Reviews.
Ts.Sandag-Ochirreading, theThreason, a misplaced row and the signal. All four are fixed in 9637ffc.Th., andtslisted under the vi language choice. Those are fixed in 7561f5b.is_leading_titlerows, aVice Yu. Petrovexample for the title-phrase head run, comment and release-log wording).Checks run locally: the full suite on 3.11 and on 3.15 (in its own environment), the serial benchmarks (all 60 pass; earlier failures were machine load, and master passed under the same load), mypy, ruff, and both Sphinx builds.
Follow-ups, not in this PR:
Md.as Muhammad written short is the largest population of this shape (2,785 ORCID credit names open with it), but it is Should a title word written after another title be the given name (Mr Sultan Khan,Mr Md Karim Uddin)? #853's question.Undram Ch.→ suffixCh.reported in the issue comment is untouched.🤖 Generated with Claude Code