Repository navigation
Read a title written joined or hyphenated at the end of a name (#1116) - #1125
Merged
Merged
Conversation
rules/H5's trailing chain asked _PERIOD_ABBREV (letters and one trailing period) before the vocabulary, so a listed title written with a period or hyphen inside it never chained at the end of a name: 'Hans Meier Priv.-Doz.' read family 'Priv.-Doz.'. The chain now asks _TRAILING_TITLE_SHAPE, the same shape widened to letters, periods and hyphens, its trailing period kept, so each such word reads as 'Prof.' does. Retires rules/S3's Accepted bullet for the Diplom degrees and the VI pack's stacked-title cost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1116) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code review: the vocabulary reads 'Dipl.‐Ing.' (U+2010, as a word processor writes it) and 'Dipl.–Ing.' as titles, but the shape took only the hyphen-minus. _HYPHENS moves to _vocab so O6 and H5 read one set; tests pin the shape's edges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nts (#1116) Design-docs review: the shape also reaches whole hyphenated title words written with a period (718 of 820 titles in no suffix set, 688 before), which decisions/vocabulary-exclusions' trailing-position line said a hyphen kept out; the reversals of #1108's and the Diplom entry's costs move to the entries' heads; the д-р renderings are one family and two middle names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Second-round review of e4bd87c: the 30 added words split 14 + 2 + 14 (two hold a period and a hyphen); д-р ends three renderings written without a comma; the head notes say 'superseded by', the form design_docs._clean strips; and the reference line names what still keeps the 102 out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ling-joined-titles # Conflicts: # tools/differential/corpus_rules.jsonl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1116.
What changes
rules/H5 (the trailing title run) checked a word's shape before asking the vocabulary. The check was
_PERIOD_ABBREV: two or more letters, then one period. So a listed title with a period or hyphen inside it was never looked up at the end of a name. It still read as a title at the front and after a comma:The chain now checks
_vocab._TRAILING_TITLE_SHAPEinstead: letters, periods and rules/O6's hyphens, starting and ending on a letter and ending in one period. Anything_PERIOD_ABBREVmatched still matches, and the front slot's H2 shape is unchanged. The vocabulary lookup after the shape check is the same one as before. I compared each widened spelling withProf.in the same names: 24 shapes × 3 spellings × 3 orders, fields and reports. All 216 rows read the same. The design-docs reviewer's own grid of 1,248 rows had no differences either._HYPHENSmoves from_post_rulesto_vocabso that O6 and H5 read one set. That meansDipl.‐Ing.with U+2010, the hyphen a word processor writes, chains too. The code review found that gap.The boundary
The final period is still required, as #1116's first option proposed.
Maria Rossi Dott.ssakeeps family 'Dott.ssa'. The Belarusian and Ukrainianд-р, which ends three CLDR renderings, stays the separate decision the issue named.What the shape reaches is the whole title vocabulary, as the period-marked spelling always did (rules/H5's Accepted bullet). Of the 820 titles in no suffix set, 718 now read as a trailing title when written with a period after them, up from 688. The 30 new ones include whole hyphenated words (
Co-Founder.,Senior-Judge.), none of which is a name. decisions/vocabulary-exclusions' trailing-position line said a hyphen kept these out; it now records the change.Measured
Against
b1d3d210, usingtools/differential/measure.py --base:Dr. Fr Rinaldo DIRICCHARDI MUZGA - PhD; Lic.Theol..Docs
Dott.ssaboundary.Hans Meier Priv.-Doz.read the listed title at the end, asHans Meier Prof.does? #1116 entry.parser_for(locales.VI)readNguyen Van Anhas family Nguyen, middle Van, given Anh, andLe Van Anhas family Le? #1108's VI entry and of the Diplom entry.Reviews
A code review and a design-docs review ran on the first two commits. Their findings are fixed in
5774eebb(hyphens) ande4bd87cb(the reach count, head notes in place of edits to the entry text, and theд-рcount). The design-docs reviewer re-checked5774eebb. A second-round review ofe4bd87cbfound four errors in its own corrections: the 30 words split 14 + 2 + 14,д-рends three renderings written without a comma, the head notes needed the "superseded by" form the docs tooling strips, and the reference line didn't say what still keeps the other 102 titles out. All four are fixed in the last commit, which changes only the decisions docs.🤖 Generated with Claude Code